-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export
fields to manifests to prevent deep imports
#4834
Conversation
Also made sure to export some utils that may not have been exported before.
export
fields to manifests to prevent deep importsexport
fields to manifests to prevent deep imports
I converted the PR to a draft since that's what the title said it was. |
Thanks I tried to look for the button for that but I guess I just missed it. |
I am not too sure how to fix |
I think that I tried adding it only to the |
make the `gatsby-node.js` fix more simple.
The only real question I have left for this PR is was flagging all affected packages as a major change right? I figured as it blocks deep imports that it likely should be counted as such. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing we don't need the types
condition since the .d.ts
file is next to the .js
file.
The only real question I have left for this PR is was flagging all affected packages as a major change right? I figured as it blocks deep imports that it likely should be counted as such.
Yeah, this is a breaking change so major
is correct.
removed `./sync` and `./async` from `@yarnpkg/libzip` Normalized some Command Class names.
I have had issues when the |
export the command from `@yarnpkg/shell`
Typescript can find the type definition files without these helpers.
I think we can go with the removes |
@@ -3,7 +3,7 @@ import {Configuration, StreamReport} from '@yarnpkg/core'; | |||
import {Command, Option, Usage} from 'clipanion'; | |||
|
|||
// eslint-disable-next-line arca/no-default-export | |||
export default class PluginListCommand extends BaseCommand { | |||
export default class PluginRuntimeCommand extends BaseCommand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning all this, btw!
Todo:
types
conditionWhat's the problem this PR addresses?
This is help with 4.x as requested in #3591
This addresses the task
Add export fields to our manifests to prevent deep imports
How did you fix it?
Added exports to all manifests.
Added exports for some things that were not exported before.
Checklist