-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(essentials)!: In a zero-install CI environment, --check-cache
or --no-check-cache
needs to be explicitly defined
#4857
Open
jj811208
wants to merge
7
commits into
yarnpkg:master
Choose a base branch
from
jj811208:feat/install-detect-environment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+76
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj811208
changed the title
Feat/install detect environment
feat(essentials):make Sep 17, 2022
install
detect CI environment
jj811208
changed the title
feat(essentials):make
feat(essentials): make Sep 17, 2022
install
detect CI environmentinstall
detect CI environment
jj811208
force-pushed
the
feat/install-detect-environment
branch
from
September 17, 2022 18:15
3bf704a
to
d8377ce
Compare
I found out how to get whether the project is a github public repository in Configuration.ts#L29-L31 but I want to know why we only focus on these
I think making all CI environments explicitly define I like yarn, but I am new at this project, maybe I missed something. |
jj811208
changed the title
feat(essentials): make
feat(essentials): In a zero-install CI environment, Sep 17, 2022
install
detect CI environment--check-cache' or
--no-check-cache' needs to be explicitly defined.
jj811208
changed the title
feat(essentials): In a zero-install CI environment,
feat(essentials): In a zero-install CI environment, Sep 17, 2022
--check-cache' or
--no-check-cache' needs to be explicitly defined.--check-cache' or
--no-check-cache' needs to be explicitly defined
jj811208
force-pushed
the
feat/install-detect-environment
branch
2 times, most recently
from
September 18, 2022 06:04
e1adcb1
to
1008f91
Compare
jj811208
changed the title
feat(essentials): In a zero-install CI environment,
feat(essentials): In a zero-install CI environment, Sep 18, 2022
--check-cache' or
--no-check-cache' needs to be explicitly defined--check-cache
or --no-check-cache
needs to be explicitly defined
jj811208
force-pushed
the
feat/install-detect-environment
branch
from
September 18, 2022 15:29
1008f91
to
b5bb7c1
Compare
jj811208
changed the title
feat(essentials): In a zero-install CI environment,
feat(essentials)!: In a zero-install CI environment, Sep 18, 2022
--check-cache
or --no-check-cache
needs to be explicitly defined--check-cache
or --no-check-cache
needs to be explicitly defined
jj811208
force-pushed
the
feat/install-detect-environment
branch
2 times, most recently
from
September 22, 2022 15:50
da2feac
to
90790ad
Compare
jj811208
force-pushed
the
feat/install-detect-environment
branch
from
October 5, 2022 12:16
90790ad
to
92de7eb
Compare
jj811208
force-pushed
the
feat/install-detect-environment
branch
from
October 22, 2022 11:20
92de7eb
to
cd8939a
Compare
`yarn install` should be explicitly defining check-cache option, if run in a CI environment and zero-install mode is enabled
`yarn install` should be explicitly defining check-cache option, if run in a CI environment and zero-install mode is enabled
jj811208
force-pushed
the
feat/install-detect-environment
branch
from
October 29, 2022 07:04
cd8939a
to
3b2a718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Related #3591
This addresses the task:
Some Thoughts:
All CI environments require users to explicitly use
--check-cache
or--no-check-cache
1. I checked github action document and ci-info package but I didn't get any help to determine if the current environment is a public repository.2. I think this is very worthwhile to use in any CI (including private repositories)
Not sure how to accurately determine if zero-install mode is enabled
I checked zero-install's documentation and read the related code, but I can't seem to tell if zero-install is enabled or not.
So, finally, I assume that the following conditions are met, representing that the zero-install mode is on
1. in a CI environment
2. pnp strict mode is enabled
3. the
.yarn/cache
directory existed before the install command execute.I can't fix the netlify deployment error, if I'm going in the right direction, we should add
--no-check-cache
on that side...
How did you fix it?
install
command is in a CI environment and zero-install mode is enabled, but not explicitly defined--check-cache
or--no-check-cache
, throws an errord43d137
a9933f2
yarn install
tests to concerns this68d2392
0fb04d3
...
Checklist