Skip to content

fix(plugin-npm): mark fetchFromNetwork private to fix TypeScript issue #6764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(plugin-npm): mark fetchFromNetwork private to fix TypeScript issue #6764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
713aedb
feat(plugin-npm): make fetchFromNetwork private
vinzscam Apr 11, 2025
de1c697
versions
vinzscam Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .yarn/versions/3d022429.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
releases:
"@yarnpkg/plugin-npm": minor

declined:
- "@yarnpkg/plugin-compat"
- "@yarnpkg/plugin-npm-cli"
- "@yarnpkg/cli"
- "@yarnpkg/core"
2 changes: 1 addition & 1 deletion packages/plugin-npm/sources/NpmHttpFetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class NpmHttpFetcher implements Fetcher {
};
}

async fetchFromNetwork(locator: Locator, opts: FetchOptions) {
private async fetchFromNetwork(locator: Locator, opts: FetchOptions) {
const {params} = structUtils.parseRange(locator.reference);
if (params === null || typeof params.__archiveUrl !== `string`)
throw new Error(`Assertion failed: The archiveUrl querystring parameter should have been available`);
Expand Down
Loading