Add documentation for opts.conditions of resolveRequest from pnpapi #6868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is the `conditions` option for the `resolveRequest` function from the pnpapi public? It's currently not documented anywhere. I came across this as part of visjs/vis-timeline#1898. `resolveRequest` would not resolve the request properly, complaining that it's not defined in the `exports` conditions of the `package.json`. Then I looked through the .pnpapi.cjs code and found that `resolveRequest` has a `conditions` option that defaults to `node, require`. After setting it to `import`, it could resolve it successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for
opts.conditionsof theresolveRequestfunction frompnpapiWhat's the problem this PR addresses?
Is the
conditionsoption for theresolveRequestfunction from the pnpapi public? It's currently not documented anywhere.I came across this as part of visjs/vis-timeline#1898.
resolveRequestwould not resolve the request properly, complaining that it's not defined in theexportsconditions of thepackage.json.Then I looked through the .pnpapi.cjs code and found that
resolveRequesthas aconditionsoption that defaults tonode, require. After setting it toimport, it could resolve it successfully.How did you fix it?
Added documentation.
Checklist
I have read the Contributing Guide.
I have set the packages that need to be released for my changes to be effective.
I will check that all automated PR checks pass before the PR gets reviewed.