Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved search to documentation index page #239

Merged
merged 18 commits into from
Nov 3, 2016
Merged

Conversation

dhruvdutt
Copy link
Contributor

Resolving #230

There's an issue in autocomplete results view.
The z-index property seems alright still it isn't filling up the area properly.

screenshot from 2016-11-03 18-11-01

screenshot from 2016-11-03 17-49-45

@jamiebuilds
Copy link
Contributor

It's not an issue with z-index, the .hero section has an overflow: hidden on it.

Could you actually move it down into the body like this though:

screen shot 2016-11-03 at 11 25 02 am

@dhruvdutt
Copy link
Contributor Author

Thanks for the design. I'll on it.

@dhruvdutt
Copy link
Contributor Author

screenshot from 2016-11-04 01-17-10

Copy link
Contributor Author

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Search documentation" won't fit in into the navbar. We should either make it "Search docs.." or adjust the width.
Make a call. I'll do it!

@jamiebuilds jamiebuilds merged commit a85c57e into yarnpkg:master Nov 3, 2016
@jamiebuilds
Copy link
Contributor

Sorry, I got to tweaking and made a bunch of changes

@dhruvdutt
Copy link
Contributor Author

Seems perfect! 💯

@hpurmann
Copy link

What do you guys think of having the search bar in the header as well? See #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants