Skip to content

Commit

Permalink
Remove Node.js check from Windows installer for now (#677)
Browse files Browse the repository at this point in the history
It doesn't handle systems such as nvm or nodemon that install Node.js without updating the registry.

References #626
  • Loading branch information
Daniel15 committed Oct 11, 2016
1 parent 0f1db96 commit 41bb88e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions resources/winsetup/Yarn.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
<MediaTemplate EmbedCab="yes" />

<!-- Ensure Node.js is installed. Can be either 32-bit or 64-bit, we don't particularly care -->
<Property Id="NODEVERSION">
<!--<Property Id="NODEVERSION">
<RegistrySearch Id="NodeVersionReg32bit" Root="HKLM" Key="SOFTWARE\Node.js" Name="Version" Type="raw" Win64="no" />
<RegistrySearch Id="NodeVersionReg64bit" Root="HKLM" Key="SOFTWARE\Node.js" Name="Version" Type="raw" Win64="yes" />
</Property>
<Condition Message="Yarn requires Node.js 4.0 or higher to be installed">NODEVERSION</Condition>
<Condition Message="Yarn requires Node.js 4.0 or higher to be installed">NODEVERSION</Condition>-->

<Feature Id="MainFeature" Title="Yarn" Level="1">
<ComponentGroupRef Id="YarnFiles" />
Expand Down

0 comments on commit 41bb88e

Please sign in to comment.