Fix yarn ls [package] command to filter properly

[wyze]

Summary

This implements #1599. Also, adds some more tests around the ls command.

Test plan

Ran against this repo.

Before

gulp

$ yarn ls gulp
yarn ls v0.17.0-0
# Omitted, but lists everything.
✨  Done in 0.40s.

once

$ yarn ls once
yarn ls v0.17.0-0
error Couldn't find package "once".
info Visit https://yarnpkg.com/en/docs/cli/ls for documentation about this command.

After

gulp

$ yarn ls gulp
yarn ls v0.17.0-0
└─ [email protected]
✨  Done in 0.44s.

once

$ yarn ls once
yarn ls v0.17.0-0
├─ [email protected]
│  └─ [email protected]
├─ [email protected]
├─ [email protected]
│  └─ [email protected]
└─ [email protected]
│  └─ [email protected]
✨  Done in 0.45s.

[markstos]

I just tested this and found it not to be working. I pulled the latest code from master, then did a gulp build, and then:

$ ./bin/yarn ls gulp
yarn ls v0.17.0-0
error An unexpected error occurred: "filters.includes is not a function".

I'm using Node.js 4.4.1.

[wyze]

Looks like that was added in a later version of Node 4.x, which is why it pass tests on CI.

[wyze]

@markstos Would you be able to test the fix-ls-args-again branch that I just pushed before I submit it for PR, please?

[markstos]

I confirmed that yarn ls gulp works as expected using Node 4.4.1 on the
fix-ls-args-again branch.

I noticed that in Travis, only Node.js 6 is tested, but from reading this
discussion [1] on the Node.js versions to support, it seems like the intent
is to at least support Node.JS releases and current releases. Since Node.js
4 is an LTS release, I recommend also testing Node 4 in Travis to avoid
failures like this in the future.

1, yarnpkg/rfcs#1

On Mon, Nov 14, 2016 at 10:34 AM, Neil Kistner [email protected]
wrote:

@markstos https://github.com/markstos Would you be able to test the
fix-ls-args-again branch that I just pushed before I submit it for PR,
please?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1792 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABk5W48T_i8wKw2Lm19wtUzzceQed2pks5q-H-PgaJpZM4KwSaz
.

Mark Stosberg
Senior Systems Engineer
RideAmigos