Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweak to allow access to lvm_vg_reuse proposal via an AY profile #875

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

mchf
Copy link
Member

@mchf mchf commented Feb 9, 2024

Problem

See yast/yast-storage-ng#1365

should be merged after the above one.

This change makes following snipped working (sets lvm_vg_reuse in created proposal(s) accordingly):

<general>
    <storage>
      <proposal>
        <lvm_vg_reuse config:type="boolean">false</lvm_vg_reuse>
      </proposal>
  </storage>
</general>

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Feb 9, 2024

Coverage Status

coverage: 68.713%. remained the same
when pulling 19903a3 on mchf:SLE-15-SP6
into a0e92a7 on yast:SLE-15-SP6.

@ancorgs
Copy link
Contributor

ancorgs commented Feb 15, 2024

This would need some update to the corresponding AY documentation, specifying what are the valid values and so on.

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, LGTM. Just some notes for the record:

  • It would have been nice to extend the unit tests at autoinst_storage_test.rb They already cover settings like lvm or encryption_password
  • I double-checked and I see the different attributes of general/proposals/storage are not mentioned in the schema, so this PR is fine as it is in that regard
  • It would be nice, nevertheless, to mention this new setting in the corresponding AutoYaST documentation

@mchf mchf merged commit ca2274d into yast:SLE-15-SP6 Feb 15, 2024
6 checks passed
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #4 successfully finished
✔️ Created IBS submit request #321659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants