add new transaction callbacks #168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
reviewed
Nov 24, 2021
src/Callbacks.cc
Outdated
|
|
||
| CB callback( ycpcb( YCPCallbacks::CB_DonePackage) ); | ||
| if (callback._set) { | ||
| // report no error, errors were already reported in problem() callback above, |
There was a problem hiding this comment.
I cannot see any problem() callback here...
There was a problem hiding this comment.
good catch. I use wrong signature. Error is not passed here at all. Errors has to be reported at the end of transaction as transaction is uninterruptable and reports all at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental support for experimental libzypp feature of rpm in single transaction. The biggest difference is error handling and disallow of aborting installation.