Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed repository and service probing (bsc#1218399) #184

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jan 19, 2024

Problem

  • https://bugzilla.suse.com/show_bug.cgi?id=1218399 - YaST adds a repository as a service
  • Libzypp 7.31.26 and newer changed the string representation of the probing result (now returns N/A instead of NONE)
  • For that reason YaST assumed the service probing succeeded (NONE = failed, anything else = success), YaST then treated the entered URL as a service URL

Solution

  • Convert the libzypp probe result to string by pkg-bindings, not by libzypp
  • Use libzypp enum in switch to ensure all values are handled there
  • Added -Werror=switch compiler option to treat missing switch cases as errors. So when libzypp adds new values the package build will fail.

Testing

  • Tested manually, repositories are now added correctly

libzypp 7.31.26 and newer changed the string representation,
convert the type to string in pkg-bindings

- 5.0.4
@lslezak lslezak merged commit 3d31448 into master Jan 19, 2024
2 checks passed
@lslezak lslezak deleted the repo_probe branch January 19, 2024 09:05
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #47 successfully finished
✔️ Created OBS submit request #1139878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants