Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if HANA DB is running on the nodes #59

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

varkoly
Copy link
Collaborator

@varkoly varkoly commented Feb 6, 2025

Problem

It was not checked whether the database is running before the installation was started.

Solution

Implementing new check for this reason

Copy link

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the indentation, the code looks good.

if @no_test
nodes.each do |node|
log.debug("node #{node} #{my_ips}")
if my_ips.include?(node)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation looks wrong.

@varkoly varkoly merged commit d552531 into yast:SLE-15-SP3 Feb 7, 2025
4 checks passed
@yast-bot
Copy link

yast-bot commented Feb 9, 2025

✔️ Internal Jenkins job #587 successfully finished
✔️ Created IBS submit request #360668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants