Migrate to Fluentd v0.14 API #4
Conversation
|
In this PR, I did not remove tag manipulation functionalities. |
Because I will add filter version of this in another PR.
rubocop -a --only Style/HashSyntax
emits -> events
| require 'uri' | ||
| end | ||
| config_param :tag, :string, default: nil | ||
| config_param :remove_prefix, :string, default: nil |
There was a problem hiding this comment.
Why not display warning with deprecated: "use @label instead for event routing" like Fluentd?
There was a problem hiding this comment.
OK. I will add deprecation messages.
There was a problem hiding this comment.
I think these configurations should be removed in next version, because these configurations are not worked well.
I've checked logic. tag_mangle method says:
tagis exclusive withadd_prefixtagis exclusive withremove_prefixadd_prefixandremove_prefixare not exclusive with each other
But in configure, following case will raise error:
- specify all
tag,add_prefixandremove_prefix - omit all
tag,add_prefixandremove_prefix
| end | ||
| config_param :tag, :string, default: nil | ||
| config_param :remove_prefix, :string, default: nil | ||
| config_param :add_prefix, :string, default: nil |
|
@yasuoza Do you have any concern? |
|
@yasuoza ping? |
|
@yasuoza FYI: Fluentd v0.14.22 has been released | Fluentd Is it hard to take time for release management? |
No description provided.