-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise exception when salesforce returns an exception for job #26
Conversation
@jthibeaux , this might help address #32 , at least clients would then be able to rescue from the Exception. Looks like it needs a rebase, though. |
@kellydunn Can you test the commit, I can rebase once I get a thumbs up |
Hope it helps! |
@yatish27 , I can confirm that I'm getting salesforce errors now instead of the ruby exception. |
Can @jthibeaux Update the PR with latest Master will merge it then |
Conflicts: lib/salesforce_bulk_api/job.rb
Updated |
rebasing and updating the gem On Mon, Aug 25, 2014 at 11:25 AM, Jeremy Thibeaux [email protected]
Yats |
raise exception when salesforce returns an exception for job
@jthibeaux Can you check if master is stable and issue is resolved. If yes i will updated the gem version and publish |
I am actually not in a good position to support this change as I am not On Sat, Sep 6, 2014 at 9:17 PM, Yatish Mehta [email protected]
|
I was attempting to test things out, and struggled with some error conditions resulting in an illegal array access as opposed to a proper exception based on what came back from Salesforce. This pull request is to simply raise an exception when Salesforce returns an exception to us, rather than expecting a job ID (which is not there in some cases).