Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign AppConfig as default #37

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

AveryLevin
Copy link

@AveryLevin AveryLevin commented Jan 25, 2024

Overview

with our upgrade to Django 4 we now need to specify which AppConfig to use as the default if there is more than 1. This PR set's that default

How to test

  • tests pass in ycharts repo

@coveralls
Copy link
Collaborator

coveralls commented Jan 25, 2024

Pull Request Test Coverage Report for Build 7661066256

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 92.438%

Totals Coverage Status
Change from base Build 7562450805: 0.009%
Covered Lines: 819
Relevant Lines: 886

💛 - Coveralls

@jpintor52
Copy link

So far I've tested the apps where I was having errors. It is working perfectly!

Copy link

@jpintor52 jpintor52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jpintor52 jpintor52 removed their assignment Jan 26, 2024
@AveryLevin AveryLevin merged commit bf97fb7 into ycharts:master Jan 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants