-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Add FAQ entry about YCM not shutting down when quitting Vim #2639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
=======================================
Coverage 87.67% 87.67%
=======================================
Files 19 19
Lines 1947 1947
=======================================
Hits 1707 1707
Misses 240 240 |
Thanks for the PR! Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. README.md, line 3027 at r1 (raw file):
I would also add here that ycmd will shut itself down after a while if it receives no requests. This time can be configured (we should mention the option name). So even in the cases where ycmd sticks around, it won't be for long. Might also be a good idea to open an issue with the vim-nerdtree-tabs project. Comments from Reviewable |
Reviewed 1 of 2 files at r2. README.md, line 3027 at r1 (raw file):
There is no option to configure it. Maybe 3 hours is a bit too long? We could reduce it to 1 hour or even 30 minutes given that we keep the server alive every 10 minutes.
See jistr/vim-nerdtree-tabs#76. Comments from Reviewable |
Just some minor questions, otherwise Reviewed 2 of 2 files at r2. README.md, line 3021 at r2 (raw file):
This is talking about ycmd not exiting. Shouldn't this line say doc/youcompleteme.txt, line 170 at r2 (raw file):
Same as the above. YCM or ycmd? doc/youcompleteme.txt, line 3308 at r2 (raw file):
Same as the above. Comments from Reviewable |
Reviewed 1 of 2 files at r1, 1 of 2 files at r2. README.md, line 3021 at r2 (raw file): Previously, bstaletic wrote…
That's intentional. Users don't necessarily know about ycmd so when encountering the issue, they will look for YCM not shutting down, not for ycmd. doc/youcompleteme.txt, line 170 at r2 (raw file): Previously, bstaletic wrote…
This file is automatically generated from Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. README.md, line 3021 at r2 (raw file): Previously, micbou wrote…
I assumed it would be something like that. I remember that I wasn't quite sure what is ycmd when I started using YCM. doc/youcompleteme.txt, line 170 at r2 (raw file): Previously, micbou wrote…
I knew one of the two files was automatically generateed. I just didn't know which. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. README.md, line 3027 at r1 (raw file): Previously, micbou wrote…
Huh, I could have sworn we had an option for it. Anyway, I'm fine with reducing it to 30 mins. We didn't use to have the heartbeat events so the value needed to be higher. README.md, line 3021 at r2 (raw file): Previously, bstaletic wrote…
I noticed this too but I assumed @micbou used YCM on purpose for the exact reason he stated above. Comments from Reviewable |
Reviewed 3 of 3 files at r3. README.md, line 3027 at r1 (raw file): Previously, Valloric (Val Markovic) wrote…
Done. Comments from Reviewable |
This seems ready, let's merge it. @micbou Thanks for the PR. @zzbot r=valloric Review status: all files reviewed at latest revision, 2 unresolved discussions. Comments from Reviewable |
📌 Commit 4e08cde has been approved by |
[READY] Add FAQ entry about YCM not shutting down when quitting Vim This issue has already been reported twice (#2403 and #2611) and is not something that we can fix on our side so we should mention it in the FAQ. Closes #2611. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2639) <!-- Reviewable:end -->
☀️ Test successful - status-travis |
This issue has already been reported twice (#2403 and #2611) and is not something that we can fix on our side so we should mention it in the FAQ.
Closes #2611.
This change is