Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Add FAQ entry about YCM not shutting down when quitting Vim #2639

Merged
merged 2 commits into from
May 15, 2017

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented May 8, 2017

This issue has already been reported twice (#2403 and #2611) and is not something that we can fix on our side so we should mention it in the FAQ.

Closes #2611.


This change is Reviewable

@codecov-io
Copy link

codecov-io commented May 8, 2017

Codecov Report

Merging #2639 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2639   +/-   ##
=======================================
  Coverage   87.67%   87.67%           
=======================================
  Files          19       19           
  Lines        1947     1947           
=======================================
  Hits         1707     1707           
  Misses        240      240

@Valloric
Copy link
Member

Valloric commented May 9, 2017

:lgtm: with minor comment.

Thanks for the PR!


Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


README.md, line 3027 at r1 (raw file):

without using the `nested` keyword (see `:h autocmd-nested`). One of these
plugins is [vim-nerdtree-tabs][]. You should identify which plugin is
responsible for the issue and report it to the plugin author.

I would also add here that ycmd will shut itself down after a while if it receives no requests. This time can be configured (we should mention the option name).

So even in the cases where ycmd sticks around, it won't be for long.

Might also be a good idea to open an issue with the vim-nerdtree-tabs project.


Comments from Reviewable

@micbou micbou force-pushed the faq-ycm-shutdown branch from 109a019 to 0fde1b5 Compare May 9, 2017 02:56
@micbou
Copy link
Collaborator Author

micbou commented May 9, 2017

Reviewed 1 of 2 files at r2.
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.


README.md, line 3027 at r1 (raw file):

This time can be configured (we should mention the option name).

There is no option to configure it. Maybe 3 hours is a bit too long? We could reduce it to 1 hour or even 30 minutes given that we keep the server alive every 10 minutes.

Might also be a good idea to open an issue with the vim-nerdtree-tabs project.

See jistr/vim-nerdtree-tabs#76.


Comments from Reviewable

@micbou micbou force-pushed the faq-ycm-shutdown branch from 0fde1b5 to ecf58f4 Compare May 9, 2017 14:48
@bstaletic
Copy link
Collaborator

Just some minor questions, otherwise :lgtm:


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.


README.md, line 3021 at r2 (raw file):

YCM does not shut down when I quit Vim

This is talking about ycmd not exiting. Shouldn't this line say ### ycmd does not shut down when I quit Vim?


doc/youcompleteme.txt, line 170 at r2 (raw file):

  34. I can't complete python packages in a virtual environment. |youcompleteme-i-cant-complete-python-packages-in-virtual-environment.|
  35. I want to defer loading of YouCompleteMe until after Vim finishes booting |i-want-to-defer-loading-of-youcompleteme-until-after-vim-finishes-booting|
  36. YCM does not shut down when I quit Vim |youcompleteme-ycm-does-not-shut-down-when-i-quit-vim|

Same as the above. YCM or ycmd?


doc/youcompleteme.txt, line 3308 at r2 (raw file):

-------------------------------------------------------------------------------
                         *youcompleteme-ycm-does-not-shut-down-when-i-quit-vim*
YCM does not shut down when I quit Vim ~

Same as the above.


Comments from Reviewable

@micbou
Copy link
Collaborator Author

micbou commented May 11, 2017

Reviewed 1 of 2 files at r1, 1 of 2 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.


README.md, line 3021 at r2 (raw file):

Previously, bstaletic wrote…

This is talking about ycmd not exiting. Shouldn't this line say ### ycmd does not shut down when I quit Vim?

That's intentional. Users don't necessarily know about ycmd so when encountering the issue, they will look for YCM not shutting down, not for ycmd.


doc/youcompleteme.txt, line 170 at r2 (raw file):

Previously, bstaletic wrote…

Same as the above. YCM or ycmd?

This file is automatically generated from README.md using the html2vimdoc tool so you don't need to review it.


Comments from Reviewable

@micbou micbou force-pushed the faq-ycm-shutdown branch from ecf58f4 to 9fd6c8e Compare May 11, 2017 00:25
@bstaletic
Copy link
Collaborator

Review status: all files reviewed at latest revision, 2 unresolved discussions.


README.md, line 3021 at r2 (raw file):

Previously, micbou wrote…

That's intentional. Users don't necessarily know about ycmd so when encountering the issue, they will look for YCM not shutting down, not for ycmd.

I assumed it would be something like that. I remember that I wasn't quite sure what is ycmd when I started using YCM.


doc/youcompleteme.txt, line 170 at r2 (raw file):

Previously, micbou wrote…

This file is automatically generated from README.md using the html2vimdoc tool so you don't need to review it.

I knew one of the two files was automatically generateed. I just didn't know which.


Comments from Reviewable

@Valloric
Copy link
Member

Review status: all files reviewed at latest revision, 2 unresolved discussions.


README.md, line 3027 at r1 (raw file):

Previously, micbou wrote…

This time can be configured (we should mention the option name).

There is no option to configure it. Maybe 3 hours is a bit too long? We could reduce it to 1 hour or even 30 minutes given that we keep the server alive every 10 minutes.

Might also be a good idea to open an issue with the vim-nerdtree-tabs project.

See jistr/vim-nerdtree-tabs#76.

Huh, I could have sworn we had an option for it.

Anyway, I'm fine with reducing it to 30 mins. We didn't use to have the heartbeat events so the value needed to be higher.


README.md, line 3021 at r2 (raw file):

Previously, bstaletic wrote…

I assumed it would be something like that. I remember that I wasn't quite sure what is ycmd when I started using YCM.

I noticed this too but I assumed @micbou used YCM on purpose for the exact reason he stated above.


Comments from Reviewable

@micbou
Copy link
Collaborator Author

micbou commented May 11, 2017

Reviewed 3 of 3 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


README.md, line 3027 at r1 (raw file):

Previously, Valloric (Val Markovic) wrote…

Huh, I could have sworn we had an option for it.

Anyway, I'm fine with reducing it to 30 mins. We didn't use to have the heartbeat events so the value needed to be higher.

Done.


Comments from Reviewable

@micbou micbou force-pushed the faq-ycm-shutdown branch from 7b4825d to aa73bab Compare May 13, 2017 01:54
@micbou micbou force-pushed the faq-ycm-shutdown branch from aa73bab to 4e08cde Compare May 15, 2017 09:20
@bstaletic
Copy link
Collaborator

This seems ready, let's merge it.

@micbou Thanks for the PR.

@zzbot r=valloric


Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@zzbot
Copy link
Contributor

zzbot commented May 15, 2017

📌 Commit 4e08cde has been approved by valloric

@zzbot
Copy link
Contributor

zzbot commented May 15, 2017

⌛ Testing commit 4e08cde with merge 61b5aa7...

zzbot added a commit that referenced this pull request May 15, 2017
[READY] Add FAQ entry about YCM not shutting down when quitting Vim

This issue has already been reported twice (#2403 and #2611) and is not something that we can fix on our side so we should mention it in the FAQ.

Closes #2611.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2639)
<!-- Reviewable:end -->
@zzbot
Copy link
Contributor

zzbot commented May 15, 2017

☀️ Test successful - status-travis
Approved by: valloric
Pushing 61b5aa7 to master...

@zzbot zzbot merged commit 4e08cde into ycm-core:master May 15, 2017
@micbou micbou deleted the faq-ycm-shutdown branch May 16, 2017 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ycmd server does not quit when vim quits.
5 participants