Skip to content

Conversation

@1NepuNep1
Copy link
Collaborator

No description provided.

@1NepuNep1 1NepuNep1 requested a review from Copilot October 23, 2025 16:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive end-to-end test coverage for YDB database engine support, including tests for DDL operations, data types, built-in functions, and various SQL query patterns. The changes also include engine and type fixes to properly support YDB-specific syntax and features.

  • DDL operations: table creation, alteration (rename, add/drop columns, alter types), and dropping tables with IF EXISTS
  • Data type mappings for YDB's type system (numeric, text, datetime, JSON, UUID, boolean types)
  • YDB-specific features: table partitioning, views, and built-in functions
  • Multiple SQL driver support: both stdlib and ydb-go-sdk packages

Reviewed Changes

Copilot reviewed 299 out of 1136 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/endtoend/testdata/ddl_drop_table_if_exists/ydb/stdlib/go/db.go Generated database interface for DROP TABLE IF EXISTS test with stdlib driver
internal/endtoend/testdata/ddl_drop_table/ydb/*/* Test files for DROP TABLE statement across multiple driver variants
internal/endtoend/testdata/ddl_create_table_partition/ydb/*/* Test files for table creation with AUTO_PARTITIONING configuration
internal/endtoend/testdata/ddl_create_table/ydb/*/* Basic table creation test files
internal/endtoend/testdata/ddl_alter_table_rename/ydb/*/* Test files for ALTER TABLE RENAME operations
internal/endtoend/testdata/ddl_alter_table_drop_column/ydb/*/* Test files for ALTER TABLE DROP COLUMN operations
internal/endtoend/testdata/ddl_alter_table_column_drop_not_null/ydb/*/* Test files for dropping NOT NULL constraints
internal/endtoend/testdata/ddl_alter_table_alter_type/ydb/*/* Test files for column type alterations using DROP/ADD pattern
internal/endtoend/testdata/ddl_alter_table_add_column/ydb/*/* Test files for ALTER TABLE ADD COLUMN operations
internal/endtoend/testdata/datatype/ydb/ydb-go-sdk/*/* Comprehensive data type mapping tests for YDB types
internal/endtoend/testdata/create_view/ydb/*/* Test files for CREATE VIEW and DROP VIEW operations
internal/endtoend/testdata/count_star/ydb/*/* Test files for COUNT(*) aggregate function
internal/endtoend/testdata/comparisons/ydb/*/* Test files for comparison operators (>, <, >=, <=, !=, <>, =)
internal/endtoend/testdata/comment_syntax/ydb/*/* Test files for SQL comment syntax support (-- and /* */)
internal/endtoend/testdata/column_as/ydb/*/* Test files for column aliasing with AS keyword
internal/endtoend/testdata/column_alias/ydb/*/* Test files for complex column aliases in SELECT statements
internal/endtoend/testdata/coalesce*/ydb/*/* Test files for COALESCE function with various scenarios
internal/endtoend/testdata/cast*/ydb/*/* Test files for CAST operations including NULL and parameter casting
internal/endtoend/testdata/case*/ydb/*/* Test files for CASE expressions with various data types
internal/endtoend/testdata/builtins/ydb/*/* Extensive tests for YDB built-in functions (Math, DateTime, Unicode modules)
internal/endtoend/testdata/between_args/ydb/*/* Test files for BETWEEN operator with parameters
internal/endtoend/testdata/array*/ydb/*/* Test files for array literals and IN operator with arrays

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@1NepuNep1 1NepuNep1 requested a review from Copilot October 27, 2025 13:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 299 out of 1138 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@1NepuNep1 1NepuNep1 merged commit 2eaa5d0 into ydb-platform:ydb Oct 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants