feat(Configs): add info about full config #2921
Conversation
Raubzeug
requested review from
artemmufazalov,
astandrik and
adameat
as code owners
|
I had to migrate from YDBSyntaxHighlighter to MonacoEditor, as the previous solution caused the interface to freeze when working with large configs. |
| }; | ||
|
|
||
| return ( | ||
| <TableWithControlsLayout fullHeight className={b(null, className)}> |
There was a problem hiding this comment.
I use here TableWithControlsLayout cause it perfectly fits. I'm going to rename TableWithControlsLayout -> SectionWithControlsLayout so it may be used not only with tables, but with whatever content.
|
@artemmufazalov all fixed, stand redeployed! |
src/containers/Cluster/Cluster.tsx
Outdated
| tabs = tabs.filter((tab) => tab.id !== clusterTabsIds.events); | ||
| skippedTabs.push(clusterTabsIds.events); | ||
| } | ||
| if (!isViewerUser) { |
There was a problem hiding this comment.
You should check if configs available here and on Node page too. Currently you only check in Diagnostics
const isFeaturesAvailable = useFeatureFlagsAvailable();
const isConfigsAvailable = useConfigAvailable();
src/containers/Cluster/Cluster.tsx
Outdated
| tabs = tabs.filter((tab) => tab.id !== clusterTabsIds.events); | ||
| skippedTabs.push(clusterTabsIds.events); | ||
| } | ||
| if (!isViewerUser) { |
There was a problem hiding this comment.
You should check also here. If no configs there still will be a tab in tablist
There was a problem hiding this comment.
Omg, sorry :) I slept very little last night
closes #2867
stand:
Cluster page
Node page
Database page
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.61 MB | Main: 85.37 MB
Diff: +0.25 MB (0.29%)
ℹ️ CI Information