Skip to content

Conversation

@DaryaVorontsova
Copy link
Contributor

@DaryaVorontsova DaryaVorontsova commented Nov 1, 2025

stand: https://nda.ya.ru/t/xahzdqYZ7MGjN4

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 375 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 47.11 MB | Main: 47.10 MB
Diff: +8.37 KB (0.02%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 1, 2025

Skipped: This PR does not contain any of your configured keywords: (greptile-review)


const VIEW_PAGES = [overview, schema, describe, access];

const STREAMING_QUERY_PAGES = [overview, topShards, nodes, describe, access];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is topShards tab here really needed? I don't see any shards for query in your stand. Please, ensure tabs list with streaming query developer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Streaming query developer answered, we need only Info, Describe, Access (without Top shards and nodes). Thanks, I will fix it

[EPathType.EPathTypeSubDomain]: false,
[EPathType.EPathTypeTableIndex]: false,
[EPathType.EPathTypeExtSubDomain]: false,
[EPathType.EPathTypeStreamingQuery]: false,
Copy link
Member

@artemmufazalov artemmufazalov Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can streaming query have children? It seems, they don't. Please, ensure it with streaming query developer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked, you're right, streaming query can't have children at all)

@artemmufazalov
Copy link
Member

artemmufazalov commented Nov 5, 2025

It better to link specific icon ticket ydb-platform/ydb#25582, rather than epic #2913. Epic should not be closed by this PR

@DaryaVorontsova DaryaVorontsova added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit c3d1764 Nov 5, 2025
7 checks passed
@DaryaVorontsova DaryaVorontsova deleted the feat/streaming-query-node-mapping branch November 5, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants