-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add Streaming Query node type and actions/controls #3041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipped: This PR does not contain any of your configured keywords: ( |
|
|
||
| const VIEW_PAGES = [overview, schema, describe, access]; | ||
|
|
||
| const STREAMING_QUERY_PAGES = [overview, topShards, nodes, describe, access]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is topShards tab here really needed? I don't see any shards for query in your stand. Please, ensure tabs list with streaming query developer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Streaming query developer answered, we need only Info, Describe, Access (without Top shards and nodes). Thanks, I will fix it
| [EPathType.EPathTypeSubDomain]: false, | ||
| [EPathType.EPathTypeTableIndex]: false, | ||
| [EPathType.EPathTypeExtSubDomain]: false, | ||
| [EPathType.EPathTypeStreamingQuery]: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can streaming query have children? It seems, they don't. Please, ensure it with streaming query developer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked, you're right, streaming query can't have children at all)
|
It better to link specific icon ticket ydb-platform/ydb#25582, rather than epic #2913. Epic should not be closed by this PR |
stand: https://nda.ya.ru/t/xahzdqYZ7MGjN4
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 47.11 MB | Main: 47.10 MB
Diff: +8.37 KB (0.02%)
ℹ️ CI Information