fix begin tx

ydb-platform · Nov 5, 2024 · 6538a32 · 6538a32
1 parent 2793c90
commit 6538a32
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/internal/table/conn/conn.go b/internal/table/conn/conn.go
@@ -448,7 +448,14 @@ func (c *Conn) ID() string {
 	return c.session.ID()
 }
 
-func (c *Conn) beginTx(ctx context.Context, txOptions driver.TxOptions) (currentTx, error) {
+func (c *Conn) beginTx(ctx context.Context, txOptions driver.TxOptions) (tx currentTx, finalErr error) {
+	onDone := trace.DatabaseSQLOnConnBegin(c.parent.Trace(), &ctx,
+		stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/table/conn.(*Conn).beginTx"),
+	)
+	defer func() {
+		onDone(tx, finalErr)
+	}()
+
 	if c.currentTx != nil {
 		return nil, badconn.Map(
 			xerrors.WithStackTrace(xerrors.AlreadyHasTx(c.currentTx.ID())),
@@ -470,13 +477,10 @@ func (c *Conn) beginTx(ctx context.Context, txOptions driver.TxOptions) (current
 }
 
 func (c *Conn) BeginTx(ctx context.Context, txOptions driver.TxOptions) (driver.Tx, error) {
-	onDone := trace.DatabaseSQLOnConnBegin(c.parent.Trace(), &ctx,
-		stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/table/conn.(*Conn).BeginTx"),
-	)
 	tx, err := c.beginTx(ctx, txOptions)
-	defer func() {
-		onDone(tx, err)
-	}()
+	if err != nil {
+		return nil, xerrors.WithStackTrace(err)
+	}
 
 	c.currentTx = tx
 

diff --git a/internal/xerrors/tx.go b/internal/xerrors/tx.go
@@ -25,5 +25,6 @@ func AlreadyHasTx(txID string) error {
 
 func IsAlreadyHasTx(err error) bool {
 	var txErr *alreadyHasTxError
+
 	return As(err, &txErr)
 }
diff --git a/tests/integration/tx_test.go b/tests/integration/tx_test.go
@@ -143,6 +143,7 @@ func TestNoEffectsIfForgetCommitTx(t *testing.T) {
 
 		// second tx on existing conn === session
 		_, err = cc.BeginTx(ctx, &sql.TxOptions{})
+		require.Error(t, err)
 		require.True(t, xerrors.IsAlreadyHasTx(err))
 	})
 }