Merge pull request #1495 from ydb-platform/fix_latency_metrics

Do not report latency metrics when metrics are disabled
ydb-platform · Oct 2, 2024 · 6fb3f52 · 6fb3f52
2 parents 05a2dde + 4e055be
commit 6fb3f52
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
+* Disabled reporting of `ydb_go_sdk_ydb_query_session_create_latency histogram metrics` when metrics are disabled
 * Allowed skip column for `ScanStruct` by tag `-` 
 
 ## v3.81.4

diff --git a/metrics/query.go b/metrics/query.go
@@ -124,8 +124,8 @@ func query(config Config) (t trace.Query) {
 						errs.With(map[string]string{
 							"status": errorBrief(info.Error),
 						}).Inc()
+						latency.With(nil).Record(time.Since(start))
 					}
-					latency.With(nil).Record(time.Since(start))
 				}
 			}
 		}