Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ifshort linter #1023

Merged
merged 40 commits into from
May 23, 2024
Merged

enable ifshort linter #1023

merged 40 commits into from
May 23, 2024

Conversation

ShishkovEM
Copy link
Contributor

@ShishkovEM ShishkovEM commented Jan 30, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #946

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: Patch coverage is 22.58065% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 40.79%. Comparing base (b7a9b51) to head (5f81a80).
Report is 160 commits behind head on master.

Files Patch % Lines
internal/table/scanner/scan_raw.go 0.00% 14 Missing ⚠️
internal/table/scanner/result.go 0.00% 0 Missing and 2 partials ⚠️
internal/table/scanner/scanner.go 0.00% 2 Missing ⚠️
internal/conn/conn.go 0.00% 1 Missing ⚠️
internal/decimal/decimal.go 75.00% 1 Missing ⚠️
internal/query/client.go 0.00% 1 Missing ⚠️
...al/topic/topicreaderinternal/stream_reconnector.go 50.00% 0 Missing and 1 partial ⚠️
internal/topic/topicwriterinternal/message.go 0.00% 0 Missing and 1 partial ⚠️
internal/xsql/tx.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
- Coverage   40.80%   40.79%   -0.01%     
==========================================
  Files         309      312       +3     
  Lines       32747    33196     +449     
==========================================
+ Hits        13361    13542     +181     
- Misses      18959    19203     +244     
- Partials      427      451      +24     
Flag Coverage Δ
go-1.21.x 42.92% <22.58%> (-0.02%) ⬇️
go-1.22.x 40.78% <22.58%> (-0.01%) ⬇️
macOS 40.23% <20.00%> (-0.07%) ⬇️
ubuntu 40.27% <20.00%> (-0.03%) ⬇️
unit 40.79% <22.58%> (-0.01%) ⬇️
windows 40.78% <22.58%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/conn/conn.go Outdated Show resolved Hide resolved
internal/topic/topicreaderinternal/stream_reconnector.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ShishkovEM
Copy link
Contributor Author

По каким-то причинам некоторые issue от ifshort не показывались у меня локально. В последнем коммите исправил те issue, которые были выявлены при автоматической проверке в джобах golangci-lint, golangci-lint-examples и golangci-lint-slo.

@asmyasnikov asmyasnikov self-assigned this Jan 31, 2024
internal/conn/conn.go Outdated Show resolved Hide resolved
@ShishkovEM ShishkovEM requested a review from asmyasnikov May 22, 2024 12:11
@asmyasnikov asmyasnikov merged commit cf01642 into ydb-platform:master May 23, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants