enabled nonamedreturns linter

[hrapovd1]

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: #958

What is the new behavior?

Other information

[rekby]

Hello.

Thanks for the PR.

You have a greak work for fix many typos in the code.
But now all tests are broken:
https://github.com/ydb-platform/ydb-go-sdk/actions/runs/7889717492/job/21734394246?pr=1033

usually it say about some mistake in one of common components.
Fix the bug please, then PR will be merged.

[asmyasnikov]

You can create a slice with predefined capacity
Because next line will re-allocate internal slice capacity

[asmyasnikov]

Alternatively you can make slice from static
Such as

opts := []grpc.DialOption{
		grpc.WithKeepaliveParams(
			DefaultGrpcConnectionPolicy,
		),
		// use round robin balancing policy for fastest dialing
		grpc.WithDefaultServiceConfig(`{
			"loadBalancingPolicy": "round_robin"
		}`),
		// limit size of outgoing and incoming packages
		grpc.WithDefaultCallOptions(
			grpc.MaxCallRecvMsgSize(DefaultGRPCMsgSize),
			grpc.MaxCallSendMsgSize(DefaultGRPCMsgSize),
		),
		// use proxy-resolvers
		// 1) for interpret schemas `ydb`, `grpc` and `grpcs` in node URLs as for dns resolver
		// 2) for observe resolving events
		grpc.WithResolvers(
			xresolver.New("", t),
			xresolver.New("ydb", t),
			xresolver.New("grpc", t),
			xresolver.New("grpcs", t),
		),
}

But on next step (if secure) append will re-allocate slice to new size

[hrapovd1]

I fixed this by adding the make with fixed capacity.

[asmyasnikov]

I think this changes not required and harmful
Because if I call getDataForITCrowd - I want to know about each of three results.
Old variant helps to understand. New variant cannot helps

[hrapovd1]

OK. I returned previous declaration.
I simple followed by linter's comment.

[asmyasnikov]

Read previous comment

[hrapovd1]

OK. I returned previous declaration.
I simple followed by linter's comment.

[asmyasnikov]

Read comment for getDataForITCrowd

[hrapovd1]

OK. I returned previous declaration.
I simple followed by linter's comment.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 51.58730% with 732 lines in your changes are missing coverage. Please review.

Project coverage is 65.73%. Comparing base (132dfcc) to head (68e1ee6).

Files	Patch %	Lines
internal/value/type.go	0.00%	520 Missing ⚠️
internal/table/scanner/scan_raw.go	26.38%	53 Missing ⚠️
internal/xsql/tx_fake.go	0.00%	37 Missing ⚠️
internal/table/scanner/scanner.go	52.38%	24 Missing and 6 partials ⚠️
internal/cmd/gtrace/writer.go	0.00%	15 Missing ⚠️
internal/xsql/conn.go	84.61%	6 Missing and 6 partials ⚠️
internal/scheme/client.go	78.43%	10 Missing and 1 partial ⚠️
internal/cmd/gtrace/main.go	0.00%	7 Missing ⚠️
internal/allocator/allocator.go	94.05%	6 Missing ⚠️
internal/table/session.go	86.36%	6 Missing ⚠️
... and 18 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   66.78%   65.73%   -1.05%     
==========================================
  Files         285      286       +1     
  Lines       27908    28711     +803     
==========================================
+ Hits        18638    18873     +235     
- Misses       8407     8977     +570     
+ Partials      863      861       -2     

Flag	Coverage Δ
	53.28% <47.88%> (-0.83%)	⬇️
go-1.21.x	67.36% <50.30%> (-1.13%)	⬇️
go-1.22.x	65.64% <51.58%> (-1.14%)	⬇️
integration	53.28% <47.88%> (-0.83%)	⬇️
macOS	37.43% <23.28%> (-0.75%)	⬇️
ubuntu	37.46% <23.34%> (-0.70%)	⬇️
unit	37.50% <23.34%> (-0.73%)	⬇️
windows	37.46% <23.28%> (-0.73%)	⬇️
ydb-22.5	50.96% <45.93%> (-0.77%)	⬇️
ydb-23.1	50.99% <45.93%> (-0.75%)	⬇️
ydb-23.2	50.98% <45.93%> (-0.93%)	⬇️
ydb-23.3	51.11% <46.07%> (-0.59%)	⬇️
ydb-24.1	53.02% <47.88%> (-0.87%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rekby]

@hrapovd1 hello.
I saw you made few commits for fixes integration tests, but it still broken.

Do you need description how to run the tests at local computer - for faster check fixes and able to run a test with debugger?

[hrapovd1]

Hello, @rekby!
Thank you for question. Could you please comment my way for tests which I'm using on local PC?
I'm testing in that way:

• create dir:
  mkdir /tmp/ydb_certs
• run ydb:
  docker run --rm -it --name ydb -p 2135:2135 -p 2136:2136 -p 8765:8765 -h localhost -e "YDB_LOCAL_SURVIVE_RESTART=true" -e "YDB_USE_IN_MEMORY_PDISKS=true" -e CI=true -v "/tmp/ydb_certs":"/ydb_certs" cr.yandex/yc/yandex-docker-local-ydb:23.2
• In the second bash session I'm export env vars:

    GO: 1.21.x
    YDB_VERSION: 22.5
    YDB_CONNECTION_STRING: grpc://localhost:2136/local
    YDB_CONNECTION_STRING_SECURE: grpcs://localhost:2135/local
    YDB_SSL_ROOT_CERTIFICATES_FILE: /tmp/ydb_certs/ca.pem
    YDB_SESSIONS_SHUTDOWN_URLS: http://localhost:8765/actors/kqp_proxy?force_shutdown=all
    HIDE_APPLICATION_OUTPUT: 1

• And run tests:
  cd ydb-go-sdk; go clean -testcache; go test -race -tags integration ./tests/integration"

[hrapovd1]

Yesterday I've committed changes in master branch of my fork because integration tests of upstream master branch had got the same errors on my local PC. And I decided that some local problems and tests will be done in CI...

[hrapovd1]

@asmyasnikov , @rekby hello! Could you please check my work and merge if it's OK?