Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added client pid to each gRPC requests to YDB over header x-ydb-client-pid #1123

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the enhancement New feature or request label Mar 12, 2024
@asmyasnikov asmyasnikov self-assigned this Mar 12, 2024
Copy link

github.com/ydb-platform/ydb-go-sdk/v3

compatible changes

WithApplicationName: added

github.com/ydb-platform/ydb-go-sdk/v3/config

compatible changes

WithApplicationName: added

github.com/ydb-platform/ydb-go-sdk/v3/meta

compatible changes

WithApplicationName: added

summary

Base version: v3.57.4-0.20240312145821-0ee201e5a612 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.57.3.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (acc1205) to head (91d7dfc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
- Coverage   67.41%   67.35%   -0.07%     
==========================================
  Files         291      291              
  Lines       28975    28984       +9     
==========================================
- Hits        19534    19521      -13     
- Misses       8543     8559      +16     
- Partials      898      904       +6     
Flag Coverage Δ
53.40% <30.00%> (-0.09%) ⬇️
go-1.21.x 69.03% <100.00%> (-0.01%) ⬇️
go-1.22.x 67.34% <100.00%> (-0.06%) ⬇️
integration 53.40% <30.00%> (-0.09%) ⬇️
macOS 39.27% <70.00%> (+0.01%) ⬆️
ubuntu 39.25% <70.00%> (-0.01%) ⬇️
unit 39.31% <70.00%> (-0.01%) ⬇️
windows 40.37% <70.00%> (+1.09%) ⬆️
ydb-23.3 50.25% <30.00%> (+0.09%) ⬆️
ydb-24.1 53.21% <30.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 0c79ad2 into master Mar 12, 2024
36 checks passed
@asmyasnikov asmyasnikov deleted the pid branch March 12, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no slo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants