Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tuple support for ydb.ParamsBuilder() #1143

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

NovruzovE
Copy link
Contributor

@NovruzovE NovruzovE commented Mar 18, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1061

What is the new behavior?

  • Support for the 'Tuple' type has been added to ydb.ParamsBuilder() for use in typed named expressions.

Other information

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (4315955) to head (e65319a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
+ Coverage   67.59%   67.69%   +0.10%     
==========================================
  Files         295      296       +1     
  Lines       29891    30000     +109     
==========================================
+ Hits        20205    20309     +104     
- Misses       8751     8756       +5     
  Partials      935      935              
Flag Coverage Δ
53.42% <0.00%> (-0.22%) ⬇️
go-1.21.x 69.16% <100.00%> (-0.03%) ⬇️
go-1.22.x 67.53% <100.00%> (+0.21%) ⬆️
integration 53.42% <0.00%> (-0.22%) ⬇️
macOS 39.63% <100.00%> (+0.22%) ⬆️
ubuntu 39.61% <100.00%> (+0.19%) ⬆️
unit 39.69% <100.00%> (+0.22%) ⬆️
windows 39.64% <100.00%> (+0.23%) ⬆️
ydb-23.3 49.23% <0.00%> (-0.13%) ⬇️
ydb-24.1 53.10% <0.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NovruzovE NovruzovE marked this pull request as ready for review March 18, 2024 14:03
@asmyasnikov asmyasnikov merged commit fa39a0b into ydb-platform:master Mar 19, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants