Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify lastUsage code #1155

Merged
merged 2 commits into from
Mar 24, 2024
Merged

simplify lastUsage code #1155

merged 2 commits into from
Mar 24, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Mar 24, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.59.1 (master)
Suggested version: v3.59.2

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.88%. Comparing base (895d516) to head (e079f4f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   67.90%   67.88%   -0.03%     
==========================================
  Files         298      298              
  Lines       30113    30115       +2     
==========================================
- Hits        20448    20443       -5     
- Misses       8738     8744       +6     
- Partials      927      928       +1     
Flag Coverage Δ
52.63% <100.00%> (+0.01%) ⬆️
go-1.21.x 69.57% <100.00%> (+0.06%) ⬆️
go-1.22.x 67.83% <100.00%> (-0.02%) ⬇️
integration 52.63% <100.00%> (+0.01%) ⬆️
macOS 40.25% <24.00%> (+0.01%) ⬆️
ubuntu 40.22% <24.00%> (-0.04%) ⬇️
unit 40.27% <24.00%> (-0.01%) ⬇️
windows 40.21% <24.00%> (-0.06%) ⬇️
ydb-23.3 47.82% <100.00%> (+0.04%) ⬆️
ydb-24.1 52.53% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 24, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Mar 24, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Mar 24, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Mar 24, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

internal/conn/conn.go Outdated Show resolved Hide resolved
@asmyasnikov asmyasnikov merged commit 0e4cf0a into master Mar 24, 2024
36 checks passed
@asmyasnikov asmyasnikov deleted the simplify branch March 24, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants