Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable forcetypeassert linter #1195

Merged
merged 18 commits into from
May 12, 2024
Merged

Conversation

korovindenis
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • [ x] Code style update (formatting, renaming)
  • [ x] Refactoring (no functional changes, no api changes)
  • [ x] Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #933

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 32.63889% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 41.04%. Comparing base (b7a9b51) to head (5a238a1).
Report is 79 commits behind head on master.

Files Patch % Lines
internal/value/nullable.go 50.00% 11 Missing and 11 partials ⚠️
internal/table/client.go 33.33% 5 Missing and 5 partials ⚠️
internal/types/types.go 0.00% 10 Missing ⚠️
internal/cmd/gtrace/writer.go 0.00% 9 Missing ⚠️
log/field.go 52.63% 4 Missing and 5 partials ⚠️
internal/value/value.go 50.00% 3 Missing and 3 partials ⚠️
internal/conn/conn.go 0.00% 4 Missing ⚠️
internal/table/transaction.go 0.00% 4 Missing ⚠️
internal/xcontext/local_dc.go 0.00% 4 Missing ⚠️
internal/xsql/rows.go 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
+ Coverage   40.80%   41.04%   +0.24%     
==========================================
  Files         309      310       +1     
  Lines       32747    33111     +364     
==========================================
+ Hits        13361    13592     +231     
- Misses      18959    19059     +100     
- Partials      427      460      +33     
Flag Coverage Δ
go-1.21.x 43.24% <34.35%> (+0.31%) ⬆️
go-1.22.x 41.04% <32.63%> (+0.24%) ⬆️
macOS ?
ubuntu 40.50% <32.62%> (+0.20%) ⬆️
unit 41.04% <32.63%> (+0.24%) ⬆️
windows 41.03% <32.63%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korovindenis
Copy link
Contributor Author

@rekby @asmyasnikov please, review

@asmyasnikov
Copy link
Member

Can you exclude forcetypeassert linter for all test files through exclude-rules in .golangci.yml?
Your changes cannot add of understanding for tests and type casts in tests not required because if some cast failed - test will failed

@korovindenis
Copy link
Contributor Author

Can you exclude forcetypeassert linter for all test files through exclude-rules in .golangci.yml? Your changes cannot add of understanding for tests and type casts in tests not required because if some cast failed - test will failed

@asmyasnikov Ok. I have made changes

@asmyasnikov asmyasnikov merged commit f97ddc7 into ydb-platform:master May 12, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants