Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

905 read topic without consumer, fix send partition number for topic reader #1238

Merged
merged 7 commits into from
May 21, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented May 20, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@rekby rekby changed the title 905 read topic without consumer 905 read topic without consumer, fix send partition number for topic reader May 20, 2024
Copy link

github-actions bot commented May 20, 2024

github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptions

compatible changes

WithReaderWithoutConsumer: added

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

TopicOnReaderStart: changed from func(*Topic, int64, string) to func(*Topic, int64, string, error)

compatible changes

TopicReaderStartInfo.Error: added

summary

Base version: v3.67.3-0.20240520181445-a9ac5e192659 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.67.2.

Copy link

github-actions bot commented May 20, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented May 20, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented May 20, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented May 20, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented May 20, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

@rekby rekby force-pushed the 905-read-topic-without-consumer branch from 3890fb6 to 19e07e8 Compare May 21, 2024 09:00
@rekby rekby merged commit c98862c into master May 21, 2024
36 checks passed
@rekby rekby deleted the 905-read-topic-without-consumer branch May 21, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant