Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace changes #1445

Merged
merged 1 commit into from
Sep 6, 2024
Merged

trace changes #1445

merged 1 commit into from
Sep 6, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

QueryOnPoolChange: changed from func(*Query, int, int) to func(*Query, int, int, int, int, int)
QueryOnPoolGet: changed from func(*Query, *context.Context, call) func(error) to func(*Query, *context.Context, call) func(session sessionInfo, attempts int, _ error)
QueryOnPoolPut: changed from func(*Query, *context.Context, call) func(error) to func(*Query, *context.Context, call, sessionInfo) func(error)
QueryOnPoolWith: changed from func(*Query, *context.Context, call) func(_ error, attempts int) to func(*Query, *context.Context, call) func(attempts int, _ error)
TableOnPoolStateChange: changed from func(*Table, int, string) to func(*Table, int, int, int, int, int, int)
TablePoolStateChangeInfo.Event: removed

compatible changes

QueryPoolChange.CreateInProgress: added
QueryPoolChange.Index: added
QueryPoolChange.Wait: added
QueryPoolGetDoneInfo.Attempts: added
QueryPoolGetDoneInfo.Session: added
QueryPoolPutStartInfo.Session: added
Table.OnPoolWith: added
TableOnPoolWith: added
TablePoolStateChangeInfo.CreateInProgress: added
TablePoolStateChangeInfo.Idle: added
TablePoolStateChangeInfo.Index: added
TablePoolStateChangeInfo.Limit: added
TablePoolStateChangeInfo.Wait: added
TablePoolWithDoneInfo: added
TablePoolWithStartInfo: added

summary

Base version: v3.79.1-0.20240906021840-f12a33e08597 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.79.0.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 63.32767% with 216 lines in your changes missing coverage. Please review.

Project coverage is 67.24%. Comparing base (f12a33e) to head (42f0271).

Files with missing lines Patch % Lines
log/table.go 71.48% 116 Missing and 18 partials ⚠️
internal/pool/pool.go 24.61% 43 Missing and 6 partials ⚠️
internal/query/client.go 0.00% 26 Missing ⚠️
metrics/table.go 66.66% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1445      +/-   ##
==========================================
- Coverage   67.47%   67.24%   -0.23%     
==========================================
  Files         350      349       -1     
  Lines       36577    36479      -98     
==========================================
- Hits        24679    24530     -149     
- Misses      10808    10849      +41     
- Partials     1090     1100      +10     
Flag Coverage Δ
experiment 71.18% <64.54%> (-0.45%) ⬇️
go-1.21.x 67.37% <62.64%> (-0.41%) ⬇️
go-1.22.x 65.11% <61.29%> (-0.26%) ⬇️
go-1.23.x 67.05% <60.61%> (-0.42%) ⬇️
integration 52.28% <64.90%> (-0.16%) ⬇️
macOS 41.07% <3.81%> (-0.13%) ⬇️
ubuntu 71.50% <67.45%> (-0.29%) ⬇️
unit 41.55% <3.90%> (-0.09%) ⬇️
windows 41.53% <3.90%> (-0.09%) ⬇️
ydb-23.3 46.94% <62.00%> (-0.38%) ⬇️
ydb-24.1 52.15% <64.90%> (-0.18%) ⬇️
ydb-nightly 71.18% <64.54%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@asmyasnikov asmyasnikov merged commit 1d8bf01 into master Sep 6, 2024
40 checks passed
@asmyasnikov asmyasnikov deleted the trace branch September 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants