Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nullable value within parambuilder #1453

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

rekby
Copy link
Member

@rekby rekby commented Sep 10, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@rekby rekby marked this pull request as draft September 10, 2024 10:20
Copy link

github-actions bot commented Sep 10, 2024

github.com/ydb-platform/ydb-go-sdk/v3

incompatible changes

Version: value changed from "3.80.7" to "3.80.8"

compatible changes

WithLazyTx: added

github.com/ydb-platform/ydb-go-sdk/v3/table/types

compatible changes

NullableDecimalValue: added
NullableDecimalValueFromBigInt: added

summary

Base version: v3.80.8-0.20240918174755-2dad31159c09 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.8.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 81.69014% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.86%. Comparing base (9cd2f73) to head (bc541e0).

Files with missing lines Patch % Lines
internal/value/nullable.go 20.00% 7 Missing and 1 partial ⚠️
table/types/value.go 20.00% 4 Missing ⚠️
internal/value/value.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
- Coverage   67.88%   67.86%   -0.02%     
==========================================
  Files         352      352              
  Lines       36420    36436      +16     
==========================================
+ Hits        24722    24727       +5     
- Misses      10611    10621      +10     
- Partials     1087     1088       +1     
Flag Coverage Δ
experiment 72.07% <85.29%> (-0.01%) ⬇️
go-1.21.x 64.67% <71.83%> (-0.19%) ⬇️
go-1.22.x 63.24% <71.83%> (-0.08%) ⬇️
go-1.23.x 67.79% <81.69%> (-0.02%) ⬇️
integration 47.55% <0.00%> (-0.02%) ⬇️
macOS 40.87% <75.00%> (-0.04%) ⬇️
ubuntu 72.30% <85.29%> (-0.02%) ⬇️
unit 41.31% <71.83%> (-0.03%) ⬇️
windows 41.28% <71.83%> (-0.04%) ⬇️
ydb-23.3 47.55% <0.00%> (-0.02%) ⬇️
ydb-nightly 72.07% <85.29%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 10, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Sep 10, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 10, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Sep 10, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Sep 10, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@asmyasnikov asmyasnikov marked this pull request as ready for review September 18, 2024 15:19
@asmyasnikov asmyasnikov merged commit 1a5e570 into master Sep 18, 2024
38 of 41 checks passed
@asmyasnikov asmyasnikov deleted the param-builder-optional branch September 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants