Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extracted query session controller logic into separated package #1457

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.80.3-0.20240911224629-a06c3b5a4266 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.2.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 87.77293% with 28 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (1b6f358) to head (802e7fb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/query/session/session.go 94.03% 8 Missing and 1 partial ⚠️
internal/query/transaction.go 55.55% 8 Missing ⚠️
internal/query/session.go 64.70% 6 Missing ⚠️
internal/query/session/status.go 71.42% 4 Missing ⚠️
internal/query/client.go 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
- Coverage   67.77%   67.75%   -0.03%     
==========================================
  Files         349      350       +1     
  Lines       36249    36283      +34     
==========================================
+ Hits        24569    24582      +13     
- Misses      10592    10611      +19     
- Partials     1088     1090       +2     
Flag Coverage Δ
experiment 71.79% <88.29%> (-0.34%) ⬇️
go-1.21.x 67.93% <79.02%> (-0.24%) ⬇️
go-1.22.x 65.58% <86.89%> (-0.18%) ⬇️
go-1.23.x 67.73% <87.77%> (-0.04%) ⬇️
integration 53.50% <77.07%> (-0.03%) ⬇️
macOS 40.93% <60.00%> (-0.07%) ⬇️
ubuntu 72.15% <88.29%> (-0.04%) ⬇️
unit 41.35% <62.44%> (-0.06%) ⬇️
windows 41.34% <62.44%> (-0.06%) ⬇️
ydb-23.3 47.59% <3.41%> (-0.21%) ⬇️
ydb-24.1 53.39% <77.07%> (-0.11%) ⬇️
ydb-nightly 71.79% <88.29%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@asmyasnikov asmyasnikov merged commit fb252b8 into master Sep 12, 2024
40 checks passed
@asmyasnikov asmyasnikov deleted the query-session branch September 12, 2024 10:52
neyguvj pushed a commit that referenced this pull request Sep 13, 2024
extracted query session controller logic into separated package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants