Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Fixed connections pool leak on failed ydb.Open call #1464

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1433

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the bug Something isn't working label Sep 16, 2024
@asmyasnikov asmyasnikov self-assigned this Sep 16, 2024
Copy link

summary

Base version: v3.80.4 (master)
Suggested version: v3.80.5

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (a827ded) to head (a4da503).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
- Coverage   67.95%   67.94%   -0.02%     
==========================================
  Files         350      350              
  Lines       36288    36289       +1     
==========================================
- Hits        24660    24655       -5     
- Misses      10551    10556       +5     
- Partials     1077     1078       +1     
Flag Coverage Δ
experiment 72.08% <100.00%> (-0.10%) ⬇️
go-1.21.x 68.14% <100.00%> (-0.03%) ⬇️
go-1.22.x 65.68% <100.00%> (-0.12%) ⬇️
go-1.23.x 67.82% <100.00%> (-0.10%) ⬇️
integration 53.91% <100.00%> (-0.06%) ⬇️
macOS 40.97% <0.00%> (-0.02%) ⬇️
ubuntu 72.36% <100.00%> (-0.02%) ⬇️
unit 41.41% <0.00%> (-0.02%) ⬇️
windows 41.40% <0.00%> (-0.01%) ⬇️
ydb-23.3 47.56% <100.00%> (-0.23%) ⬇️
ydb-24.1 53.84% <100.00%> (+0.04%) ⬆️
ydb-nightly 72.08% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 89a10b0 into master Sep 16, 2024
41 checks passed
@asmyasnikov asmyasnikov deleted the pool-leak branch September 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants