Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent map writes in metrics #1468

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

neyguvj
Copy link
Collaborator

@neyguvj neyguvj commented Sep 17, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.80.6-0.20240917094259-e582517397b8 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.5.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (e582517) to head (4f959f2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
- Coverage   68.00%   67.87%   -0.14%     
==========================================
  Files         350      350              
  Lines       36289    36292       +3     
==========================================
- Hits        24678    24632      -46     
- Misses      10536    10576      +40     
- Partials     1075     1084       +9     
Flag Coverage Δ
experiment 72.13% <100.00%> (-0.08%) ⬇️
go-1.21.x 68.02% <100.00%> (-0.27%) ⬇️
go-1.22.x 65.69% <100.00%> (-0.24%) ⬇️
go-1.23.x 67.85% <100.00%> (-0.08%) ⬇️
integration 53.61% <100.00%> (-0.44%) ⬇️
macOS 40.97% <0.00%> (-0.02%) ⬇️
ubuntu 72.28% <100.00%> (-0.16%) ⬇️
unit 41.41% <0.00%> (-0.02%) ⬇️
windows 41.40% <0.00%> (-0.03%) ⬇️
ydb-23.3 47.62% <100.00%> (-0.24%) ⬇️
ydb-24.1 53.44% <100.00%> (-0.55%) ⬇️
ydb-nightly 72.13% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@neyguvj neyguvj merged commit 66ffc00 into master Sep 17, 2024
41 checks passed
@neyguvj neyguvj deleted the fix-cincurrent-map-writes branch September 17, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants