Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ydb_go_sdk_ydb_query_pool_size_limit metrics #1469

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

neyguvj
Copy link
Collaborator

@neyguvj neyguvj commented Sep 18, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.80.8-0.20240918131808-2b3958d9e2c5 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.7.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.95%. Comparing base (2b3958d) to head (8410fa9).

Files with missing lines Patch % Lines
metrics/query.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
+ Coverage   67.94%   67.95%   +0.01%     
==========================================
  Files         350      350              
  Lines       36292    36293       +1     
==========================================
+ Hits        24658    24663       +5     
+ Misses      10557    10553       -4     
  Partials     1077     1077              
Flag Coverage Δ
experiment 72.02% <50.00%> (-0.14%) ⬇️
go-1.21.x 68.12% <50.00%> (-0.06%) ⬇️
go-1.22.x 65.83% <50.00%> (+0.02%) ⬆️
go-1.23.x 67.74% <50.00%> (-0.13%) ⬇️
integration 53.93% <50.00%> (+0.05%) ⬆️
macOS 40.94% <0.00%> (-0.04%) ⬇️
ubuntu 72.37% <50.00%> (+0.01%) ⬆️
unit 41.41% <0.00%> (-0.01%) ⬇️
windows 41.40% <0.00%> (-0.02%) ⬇️
ydb-23.3 47.63% <50.00%> (-0.02%) ⬇️
ydb-24.1 53.73% <50.00%> (-0.12%) ⬇️
ydb-nightly 72.02% <50.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

@asmyasnikov asmyasnikov merged commit f440187 into master Sep 18, 2024
41 checks passed
@asmyasnikov asmyasnikov deleted the add-query-pool-index-metrics branch September 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants