Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added ydb.WithLazyTx() option for create lazy transactions on query.Session.Begin call #1471

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.79%. Comparing base (2dad311) to head (7ff6caa).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/query/client.go 50.00% 1 Missing ⚠️
internal/query/config/options.go 75.00% 1 Missing ⚠️
internal/query/session.go 94.11% 1 Missing ⚠️
internal/tx/id.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
- Coverage   67.90%   67.79%   -0.12%     
==========================================
  Files         352      352              
  Lines       36398    36420      +22     
==========================================
- Hits        24716    24690      -26     
- Misses      10594    10632      +38     
- Partials     1088     1098      +10     
Flag Coverage Δ
experiment 72.16% <96.77%> (-0.04%) ⬇️
go-1.21.x 64.70% <51.42%> (-3.30%) ⬇️
go-1.22.x 63.32% <50.00%> (-2.33%) ⬇️
go-1.23.x 67.75% <88.88%> (-0.12%) ⬇️
integration 47.49% <22.58%> (-6.45%) ⬇️
macOS 40.88% <38.70%> (-0.02%) ⬇️
ubuntu 72.22% <96.77%> (-0.12%) ⬇️
unit 41.33% <38.88%> (-0.02%) ⬇️
windows 41.31% <38.88%> (-0.04%) ⬇️
ydb-23.3 47.49% <22.58%> (-0.17%) ⬇️
ydb-24.1 ?
ydb-nightly 72.16% <96.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 18, 2024

github.com/ydb-platform/ydb-go-sdk/v3

compatible changes

WithLazyTx: added

summary

Base version: v3.80.8-0.20240918174755-2dad31159c09 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.7.

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@asmyasnikov asmyasnikov merged commit 6dc693a into master Sep 18, 2024
37 of 40 checks passed
@asmyasnikov asmyasnikov deleted the with-lazy-tx branch September 18, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants