Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some refactor of experimental topic helpers #1475

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Sep 18, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@rekby rekby added the no slo label Sep 18, 2024
Copy link

github.com/ydb-platform/ydb-go-sdk/v3/topic/topicsugar

incompatible changes

TopicUnmarshalJSONFunc: removed
TopicUnmarshalJSONIterator: removed

compatible changes

BytesIterator: added
IteratorFunc: added
JSONIterator: added
ProtobufIterator: added
StringIterator: added

summary

Base version: v3.80.9 (master)
Cannot suggest a release version.
Incompatible changes were detected.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.88%. Comparing base (4d75f71) to head (eb6cb0c).

Files with missing lines Patch % Lines
topic/topicsugar/iterators.go 30.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1475      +/-   ##
==========================================
- Coverage   67.99%   67.88%   -0.11%     
==========================================
  Files         352      352              
  Lines       36436    36455      +19     
==========================================
- Hits        24773    24747      -26     
- Misses      10583    10619      +36     
- Partials     1080     1089       +9     
Flag Coverage Δ
experiment 72.14% <43.75%> (-0.08%) ⬇️
go-1.21.x 68.14% <ø> (-0.06%) ⬇️
go-1.22.x 65.73% <ø> (-0.01%) ⬇️
go-1.23.x 67.83% <33.33%> (-0.05%) ⬇️
integration 54.08% <43.75%> (-0.14%) ⬇️
macOS 40.86% <0.00%> (-0.02%) ⬇️
ubuntu 72.33% <43.75%> (-0.12%) ⬇️
unit 41.29% <0.00%> (-0.03%) ⬇️
windows 41.29% <0.00%> (-0.03%) ⬇️
ydb-23.3 47.45% <37.50%> (-0.22%) ⬇️
ydb-24.1 53.94% <43.75%> (-0.17%) ⬇️
ydb-24.2 53.94% <43.75%> (-0.05%) ⬇️
ydb-nightly 72.14% <43.75%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

@rekby rekby merged commit f4c4c8a into master Sep 18, 2024
44 checks passed
@rekby rekby deleted the topic-unmarshap-protobuf-helper branch September 18, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants