Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added ydb.WithSessionPoolSessionUsageLimit() option for limitation max count of session usage #1476

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.91%. Comparing base (f4c4c8a) to head (2f69e79).

Files with missing lines Patch % Lines
options.go 0.00% 5 Missing ⚠️
internal/query/config/options.go 0.00% 4 Missing ⚠️
internal/table/config/config.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
- Coverage   68.04%   67.91%   -0.14%     
==========================================
  Files         352      352              
  Lines       36455    36482      +27     
==========================================
- Hits        24805    24775      -30     
- Misses      10576    10621      +45     
- Partials     1074     1086      +12     
Flag Coverage Δ
experiment 72.15% <56.00%> (-0.20%) ⬇️
go-1.21.x 68.19% <59.25%> (-0.14%) ⬇️
go-1.22.x 65.81% <55.17%> (-0.19%) ⬇️
go-1.23.x 67.83% <55.17%> (-0.15%) ⬇️
integration 54.11% <52.00%> (-0.23%) ⬇️
macOS 40.85% <44.00%> (-0.02%) ⬇️
ubuntu 72.36% <56.00%> (-0.16%) ⬇️
unit 41.32% <44.82%> (+0.01%) ⬆️
windows 41.31% <44.82%> (+0.02%) ⬆️
ydb-23.3 47.51% <40.00%> (-0.30%) ⬇️
ydb-24.1 53.99% <52.00%> (-0.26%) ⬇️
ydb-24.2 53.89% <52.00%> (-0.33%) ⬇️
ydb-nightly 72.15% <56.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github.com/ydb-platform/ydb-go-sdk/v3

compatible changes

WithSessionPoolSessionUsageLimit: added

summary

Base version: v3.80.10-0.20240918212139-f4c4c8ac7e9f (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.9.

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@asmyasnikov asmyasnikov merged commit a16161a into master Sep 19, 2024
44 checks passed
@asmyasnikov asmyasnikov deleted the limit-usage branch September 19, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants