Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-listener-close #1485

Merged
merged 8 commits into from
Oct 4, 2024
Merged

fix-listener-close #1485

merged 8 commits into from
Oct 4, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Sep 25, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (28775df) to head (896a012).

Files with missing lines Patch % Lines
...nal/topic/topiclistenerinternal/stream_listener.go 60.00% 5 Missing and 1 partial ⚠️
...opiclistenerinternal/topic_listener_reconnector.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1485      +/-   ##
==========================================
- Coverage   66.95%   66.91%   -0.05%     
==========================================
  Files         353      353              
  Lines       36687    36695       +8     
==========================================
- Hits        24565    24554      -11     
- Misses      11042    11055      +13     
- Partials     1080     1086       +6     
Flag Coverage Δ
experiment 71.11% <53.33%> (-0.05%) ⬇️
go-1.21.x 67.16% <50.00%> (-0.03%) ⬇️
go-1.22.x 64.86% <50.00%> (-0.01%) ⬇️
go-1.23.x 66.89% <50.00%> (-0.06%) ⬇️
integration 53.00% <53.33%> (-0.06%) ⬇️
macOS 40.75% <0.00%> (-0.01%) ⬇️
ubuntu 71.20% <53.33%> (-0.05%) ⬇️
unit 41.17% <5.55%> (-0.02%) ⬇️
windows 41.17% <5.55%> (-0.02%) ⬇️
ydb-23.3 46.58% <53.33%> (-0.07%) ⬇️
ydb-24.1 52.94% <53.33%> (-0.06%) ⬇️
ydb-24.2 52.98% <53.33%> (-0.05%) ⬇️
ydb-nightly 71.11% <53.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 25, 2024

summary

Base version: v3.81.5-0.20241002182517-28775df1584a (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.81.4.

Copy link

github-actions bot commented Oct 3, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Oct 3, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Oct 3, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Oct 3, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Oct 3, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@rekby rekby force-pushed the fix-listener-close branch from 013818e to 792d24d Compare October 4, 2024 09:10
@rekby rekby merged commit 96ddb14 into master Oct 4, 2024
44 checks passed
@rekby rekby deleted the fix-listener-close branch October 4, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants