Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bulk upsert from scv, arrow and ydb internal formats #1491

Merged

Conversation

UgnineSirdis
Copy link
Contributor

@UgnineSirdis UgnineSirdis commented Oct 1, 2024

Support bulk upsert from scv, arrow and ydb internal formats

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 48 lines in your changes missing coverage. Please review.

Project coverage is 66.85%. Comparing base (e5f377a) to head (f90d5a1).

Files with missing lines Patch % Lines
table/table.go 65.00% 29 Missing and 6 partials ⚠️
internal/table/client.go 62.85% 10 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1491      +/-   ##
==========================================
- Coverage   66.90%   66.85%   -0.06%     
==========================================
  Files         353      353              
  Lines       36695    36829     +134     
==========================================
+ Hits        24552    24622      +70     
- Misses      11055    11109      +54     
- Partials     1088     1098      +10     
Flag Coverage Δ
experiment 71.05% <81.48%> (-0.04%) ⬇️
go-1.21.x 67.02% <64.70%> (-0.07%) ⬇️
go-1.22.x 64.77% <64.70%> (-0.06%) ⬇️
go-1.23.x 66.83% <64.70%> (-0.02%) ⬇️
integration 52.83% <81.48%> (-0.17%) ⬇️
macOS 40.60% <0.92%> (-0.14%) ⬇️
ubuntu 71.19% <81.48%> (-0.01%) ⬇️
unit 41.02% <0.73%> (-0.16%) ⬇️
windows 40.99% <0.73%> (-0.18%) ⬇️
ydb-23.3 46.61% <81.48%> (+0.07%) ⬆️
ydb-24.1 52.72% <81.48%> (-0.24%) ⬇️
ydb-24.2 52.74% <81.48%> (-0.22%) ⬇️
ydb-nightly 71.05% <81.48%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

table/table.go Outdated Show resolved Hide resolved
table/table.go Outdated Show resolved Hide resolved
@asmyasnikov asmyasnikov self-assigned this Oct 4, 2024
@asmyasnikov asmyasnikov changed the base branch from master to bulk-upsert October 4, 2024 15:31
@asmyasnikov asmyasnikov merged commit 3637f53 into ydb-platform:bulk-upsert Oct 4, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants