Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of BulkUpsert over table client instead table session #1497

Merged
merged 20 commits into from
Oct 6, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added enhancement New feature or request table labels Oct 4, 2024
@asmyasnikov asmyasnikov self-assigned this Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

github.com/ydb-platform/ydb-go-sdk/v3/table

incompatible changes

Client.BulkUpsert: added

compatible changes

BulkUpsertData: added
BulkUpsertDataArrow: added
BulkUpsertDataCsv: added
BulkUpsertDataRows: added
WithArrowSchema: added
WithCsvDelimiter: added
WithCsvHeader: added
WithCsvNullValue: added
WithCsvSkipRows: added

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

TableBulkUpsertDoneInfo: changed from TableBulkUpsertDoneInfo to TableBulkUpsertDoneInfo
TableBulkUpsertStartInfo.Session: removed
TableBulkUpsertStartInfo: changed from TableBulkUpsertStartInfo to TableBulkUpsertStartInfo
TableOnSessionBulkUpsert: changed from func(*Table, *context.Context, call, sessionInfo) func(error) to func(*Table, *context.Context, call) func(error)

compatible changes

Table.OnBulkUpsert: added
TableOnBulkUpsert: added
TableSessionBulkUpsertDoneInfo: added
TableSessionBulkUpsertStartInfo: added

summary

Base version: v3.82.0 (master)
Cannot suggest a release version.
Incompatible changes were detected.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 82.81250% with 22 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (e5f377a) to head (6b2fbf8).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
internal/table/client.go 60.97% 12 Missing and 4 partials ⚠️
table/table.go 93.10% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
- Coverage   66.97%   66.91%   -0.06%     
==========================================
  Files         353      353              
  Lines       36695    36822     +127     
==========================================
+ Hits        24576    24640      +64     
- Misses      11039    11087      +48     
- Partials     1080     1095      +15     
Flag Coverage Δ
experiment 71.10% <88.23%> (-0.07%) ⬇️
go-1.21.x 67.15% <82.81%> (-0.08%) ⬇️
go-1.22.x 64.77% <82.81%> (-0.12%) ⬇️
go-1.23.x 66.88% <82.81%> (-0.05%) ⬇️
integration 52.82% <88.23%> (-0.29%) ⬇️
macOS 40.79% <63.72%> (+0.04%) ⬆️
ubuntu 71.20% <88.23%> (-0.07%) ⬇️
unit 41.25% <63.28%> (+0.06%) ⬆️
windows 41.24% <63.28%> (+0.06%) ⬆️
ydb-23.3 46.61% <88.23%> (-0.07%) ⬇️
ydb-24.1 52.76% <88.23%> (-0.26%) ⬇️
ydb-24.2 52.73% <88.23%> (-0.28%) ⬇️
ydb-nightly 71.10% <88.23%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 4, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Oct 4, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Oct 4, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Oct 4, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Oct 4, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@asmyasnikov asmyasnikov merged commit c7d991f into master Oct 6, 2024
44 checks passed
@asmyasnikov asmyasnikov deleted the bulk-upsert branch October 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request table
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants