Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improove error text #1498

Merged
merged 2 commits into from
Nov 11, 2024
Merged

improove error text #1498

merged 2 commits into from
Nov 11, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Oct 7, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@rekby rekby added enhancement New feature or request no changelog no slo labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

summary

Base version: v3.83.0 (master)
Suggested version: v3.83.1

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.94%. Comparing base (e5f377a) to head (f2b5a08).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
- Coverage   66.97%   66.94%   -0.03%     
==========================================
  Files         353      353              
  Lines       36695    36822     +127     
==========================================
+ Hits        24576    24652      +76     
- Misses      11039    11077      +38     
- Partials     1080     1093      +13     
Flag Coverage Δ
experiment 71.09% <ø> (-0.08%) ⬇️
go-1.21.x 67.11% <ø> (-0.11%) ⬇️
go-1.22.x 64.84% <ø> (-0.05%) ⬇️
go-1.23.x 66.88% <ø> (-0.05%) ⬇️
integration 53.07% <ø> (-0.03%) ⬇️
macOS 40.81% <ø> (+0.06%) ⬆️
ubuntu 71.24% <ø> (-0.03%) ⬇️
unit 41.24% <ø> (+0.05%) ⬆️
windows 41.23% <ø> (+0.05%) ⬆️
ydb-23.3 46.60% <ø> (-0.09%) ⬇️
ydb-24.1 52.97% <ø> (-0.04%) ⬇️
ydb-24.2 53.03% <ø> (+0.02%) ⬆️
ydb-nightly 71.09% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekby rekby merged commit 6e8ca8f into master Nov 11, 2024
43 checks passed
@rekby rekby deleted the improve-wrong-commit-order-error branch November 11, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants