Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonization of current uuid behavior #1505

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

rekby
Copy link
Member

@rekby rekby commented Oct 10, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.84.2-0.20241009164026-848edf6fa0dd (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.84.1.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.00%. Comparing base (848edf6) to head (2f4905c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
+ Coverage   66.98%   67.00%   +0.01%     
==========================================
  Files         353      353              
  Lines       36825    36825              
==========================================
+ Hits        24667    24674       +7     
+ Misses      11069    11050      -19     
- Partials     1089     1101      +12     
Flag Coverage Δ
experiment 71.17% <ø> (+<0.01%) ⬆️
go-1.21.x 67.09% <ø> (-0.15%) ⬇️
go-1.22.x 64.92% <ø> (-0.05%) ⬇️
go-1.23.x 66.98% <ø> (+0.01%) ⬆️
integration 53.26% <ø> (+0.11%) ⬆️
macOS 40.81% <ø> (-0.01%) ⬇️
ubuntu 71.30% <ø> (+0.02%) ⬆️
unit 41.24% <ø> (-0.03%) ⬇️
windows 41.23% <ø> (-0.03%) ⬇️
ydb-23.3 48.72% <ø> (+1.94%) ⬆️
ydb-24.1 52.98% <ø> (-0.15%) ⬇️
ydb-24.2 53.19% <ø> (+0.10%) ⬆️
ydb-nightly 71.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekby rekby merged commit 84a2b9b into master Oct 10, 2024
43 checks passed
@rekby rekby deleted the add-test-old-uuid-serialization branch October 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants