Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added query.WithPoolID() execute option #1521

Merged
merged 3 commits into from
Oct 22, 2024
Merged

* Added query.WithPoolID() execute option #1521

merged 3 commits into from
Oct 22, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1519

What is the new behavior?

Other information

Copy link

github.com/ydb-platform/ydb-go-sdk/v3/query

compatible changes

WithPoolID: added

summary

Base version: v3.85.1 (master)
Suggested version: v3.86.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.85%. Comparing base (b958288) to head (3e21558).

Files with missing lines Patch % Lines
query/execute_options.go 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1521      +/-   ##
==========================================
- Coverage   70.87%   70.85%   -0.03%     
==========================================
  Files         356      356              
  Lines       37180    37190      +10     
==========================================
- Hits        26353    26352       -1     
- Misses       9725     9734       +9     
- Partials     1102     1104       +2     
Flag Coverage Δ
experiment 70.62% <84.61%> (-0.13%) ⬇️
go-1.21.x 70.24% <84.61%> (-0.09%) ⬇️
go-1.22.x 68.25% <84.61%> (-0.19%) ⬇️
go-1.23.x 70.80% <84.61%> (-0.07%) ⬇️
integration 52.16% <69.23%> (-0.04%) ⬇️
macOS 40.88% <34.61%> (-0.16%) ⬇️
ubuntu 70.85% <84.61%> (-0.02%) ⬇️
unit 40.91% <34.61%> (-0.14%) ⬇️
windows 40.89% <34.61%> (-0.16%) ⬇️
ydb-23.3 47.71% <26.92%> (-0.16%) ⬇️
ydb-24.1 52.00% <69.23%> (-0.16%) ⬇️
ydb-24.2 52.03% <69.23%> (-0.13%) ⬇️
ydb-nightly 70.62% <84.61%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@asmyasnikov asmyasnikov merged commit 4adacff into master Oct 22, 2024
44 checks passed
@asmyasnikov asmyasnikov deleted the pool-id branch October 22, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants