UUID break old code #1523
Merged
UUID break old code #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/bind/params.go
# Conflicts: # internal/table/scanner/scanner.go # internal/value/value.go # tests/integration/database_sql_regression_test.go
# Conflicts: # internal/scanner/scanner.go
# Conflicts: # tests/integration/database_sql_regression_test.go
# Conflicts: # internal/params/parameters.go # table/types/value.go
# Conflicts: # CHANGELOG.md
github.com/ydb-platform/ydb-go-sdk/v3/table/typesincompatible changesUUIDValue: removed compatible changesErrIssue1501BadUUID: added summaryBase version: v3.86.1 (master) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1523 +/- ##
==========================================
+ Coverage 70.94% 71.05% +0.11%
==========================================
Files 356 356
Lines 37550 37531 -19
==========================================
+ Hits 26638 26666 +28
+ Misses 9793 9760 -33
+ Partials 1119 1105 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
qrort
reviewed
Oct 23, 2024
| @@ -1,5 +1,9 @@ | |||
| * BREAK OLD STYLE WORK WITH UUID. See https://github.com/ydb-platform/ydb-go-sdk/issues/1501 for details. | |||
| At the version you must explicit choose way for work with uuid: old with bug or new (fixed). | |||
There was a problem hiding this comment.
Suggested change
| At the version you must explicit choose way for work with uuid: old with bug or new (fixed). | |
| This version, you must explicit choose way to work with uuid: old, with bug, or new (fixed). |
| ## v3.86.0 | ||
| * Add workaround for bug in uuid send/receive from server. It is migration version. All native code and most database sql code worked with uuid continue to work. | ||
| Dedicated version for migrate code for workaround/fix uuid bug. See https://github.com/ydb-platform/ydb-go-sdk/issues/1501 for details. |
There was a problem hiding this comment.
Suggested change
| Dedicated version for migrate code for workaround/fix uuid bug. See https://github.com/ydb-platform/ydb-go-sdk/issues/1501 for details. | |
| Dedicated version to enable code migration from buggy way of sending UUID data to server to correct implementation. See https://github.com/ydb-platform/ydb-go-sdk/issues/1501 for details. |
# Conflicts: # CHANGELOG.md
|
🌋 Here are results of SLO test for Go SDK database/sql: |
|
🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service: |
|
🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service: |
|
🌋 Here are results of SLO test for Go SDK xorm: |
|
🌋 Here are results of SLO test for Go SDK gorm: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information