Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scan to uuid #1524

Merged
merged 1 commit into from
Oct 23, 2024
Merged

add scan to uuid #1524

merged 1 commit into from
Oct 23, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Oct 23, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.86.0 (master)
Suggested version: v3.86.1

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (bcbe650) to head (a22f63d).

Files with missing lines Patch % Lines
internal/table/scanner/scanner.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
- Coverage   71.03%   70.96%   -0.08%     
==========================================
  Files         356      356              
  Lines       37543    37550       +7     
==========================================
- Hits        26668    26646      -22     
- Misses       9764     9788      +24     
- Partials     1111     1116       +5     
Flag Coverage Δ
experiment 70.82% <0.00%> (-0.07%) ⬇️
go-1.21.x 70.42% <0.00%> (-0.10%) ⬇️
go-1.22.x 68.43% <0.00%> (-0.09%) ⬇️
go-1.23.x 70.95% <0.00%> (-0.08%) ⬇️
integration 52.11% <0.00%> (-0.10%) ⬇️
macOS 41.03% <0.00%> (-0.01%) ⬇️
ubuntu 70.95% <0.00%> (-0.08%) ⬇️
unit 41.04% <0.00%> (-0.01%) ⬇️
windows 41.01% <0.00%> (-0.04%) ⬇️
ydb-23.3 47.77% <0.00%> (-0.20%) ⬇️
ydb-24.1 51.67% <0.00%> (-0.45%) ⬇️
ydb-24.2 52.03% <0.00%> (-0.11%) ⬇️
ydb-nightly 70.82% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekby rekby merged commit d892eeb into master Oct 23, 2024
44 checks passed
@rekby rekby deleted the uuid-fix branch October 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants