allow to use common balancer in child drivers #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmyasnikov
reviewed
Oct 25, 2024
asmyasnikov
reviewed
Oct 25, 2024
asmyasnikov
reviewed
Oct 25, 2024
asmyasnikov
reviewed
Oct 25, 2024
asmyasnikov
reviewed
Oct 25, 2024
|
🌋 Here are results of SLO test for Go SDK database/sql: |
|
🌋 Here are results of SLO test for Go SDK gorm: |
|
🌋 Here are results of SLO test for Go SDK xorm: |
|
🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service: |
|
🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service: |
asmyasnikov
reviewed
Oct 25, 2024
with.go
Outdated
| @@ -19,9 +19,6 @@ func (d *Driver) with(ctx context.Context, opts ...Option) (*Driver, uint64, err | |||
| append( | |||
| append( | |||
| d.opts, | |||
| WithBalancer( | |||
asmyasnikov
reviewed
Oct 25, 2024
driver.go
Outdated
| d.balancer, err = balancer.New(ctx, d.config, d.pool, d.discoveryOptions...) | ||
| if d.balancer == nil { | ||
| d.balancer, err = balancer.New(ctx, d.config, d.pool, d.discoveryOptions...) | ||
| } | ||
| if err != nil { |
github.com/ydb-platform/ydb-go-sdk/v3compatible changesWithSharedBalancer: added summaryBase version: v3.89.0 (master) |
neyguvj
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1530 +/- ##
==========================================
- Coverage 71.03% 70.88% -0.16%
==========================================
Files 356 356
Lines 37483 37490 +7
==========================================
- Hits 26627 26573 -54
- Misses 9754 9803 +49
- Partials 1102 1114 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
asmyasnikov
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information