-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* Refactored database/sql
driver internals for query-service client support in the future
#1535
Conversation
internal/xsql
to internal/{xsql,table/conn,query/conn}
github.com/ydb-platform/ydb-go-sdk/v3incompatible changes./internal/xsql.ConnectorOption.Apply: changed from func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/xsql.Connector) error to func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/connector.Connector) error summaryBase version: v3.89.5 (master) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
- Coverage 70.94% 70.80% -0.15%
==========================================
Files 356 362 +6
Lines 37538 37507 -31
==========================================
- Hits 26633 26555 -78
- Misses 9799 9860 +61
+ Partials 1106 1092 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eaa1747
to
e57b1a1
Compare
internal/xsql
to internal/{xsql,table/conn,query/conn}
database/sql
driver internals for query-service client support in the future
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information