-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid retrying requests finished with 'UNAUTHORIZED' errors #1563
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1563 +/- ##
==========================================
- Coverage 71.13% 70.94% -0.20%
==========================================
Files 363 363
Lines 37576 37581 +5
==========================================
- Hits 26731 26660 -71
- Misses 9767 9833 +66
- Partials 1078 1088 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github.com/ydb-platform/ydb-go-sdk/v3incompatible changesConnectorOption: changed from github.com/ydb-platform/ydb-go-sdk/v3/internal/connector.Option to Option summaryBase version: v3.92.4 (master) |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
All YDB errors are retryable now with no exceptions. This causes hanging of
driver.Table().Do()
calls in case if invalid credentials were provided.Issue Number: #1550.
What is the new behavior?
Errors with code
UNAUTHORIZED
are returned immediately to the caller.Other information
Fixes #1550 and YQ-3843.