Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development environment configuration with YDB #1570

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

polRk
Copy link
Member

@polRk polRk commented Nov 29, 2024

This pull request introduces a development container setup for the project, including Docker configurations, environment settings, and dependency management. The main changes involve the creation of Docker and Docker Compose files, a configuration script, and a Dependabot configuration for automated dependency updates.

Development container setup:

  • .devcontainer/Dockerfile: Added a Dockerfile to set up a Go development environment with golangci-lint installed.
  • .devcontainer/compose.yml: Introduced a Docker Compose file to define services for the SDK and YDB, including volume mounts and environment variables.
  • .devcontainer/configure.sh: Added a shell script to configure YDB profiles within the development container.
  • .devcontainer/devcontainer.json: Created a devcontainer configuration file to specify container settings, such as forwarded ports, VS Code extensions, and initialization commands.

Dependency management:

  • .github/dependabot.yml: Added a Dependabot configuration to automate dependency updates for the development container setup on a weekly schedule.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): devcontainer with YDB

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github.com/ydb-platform/ydb-go-sdk/v3

incompatible changes

ConnectorOption: changed from github.com/ydb-platform/ydb-go-sdk/v3/internal/connector.Option to Option

summary

Base version: v3.92.7-0.20241123092125-a63ea4f5feb3 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.92.6.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.03%. Comparing base (a63ea4f) to head (ce8a690).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
- Coverage   71.07%   71.03%   -0.05%     
==========================================
  Files         363      363              
  Lines       37665    37665              
==========================================
- Hits        26771    26754      -17     
- Misses       9812     9826      +14     
- Partials     1082     1085       +3     
Flag Coverage Δ
experiment 70.77% <ø> (-0.16%) ⬇️
go-1.21.x 70.38% <ø> (-0.14%) ⬇️
go-1.22.x 68.43% <ø> (-0.11%) ⬇️
go-1.23.x 70.94% <ø> (-0.11%) ⬇️
integration 52.14% <ø> (-0.40%) ⬇️
macOS 41.09% <ø> (-0.02%) ⬇️
ubuntu 71.03% <ø> (-0.05%) ⬇️
unit 41.10% <ø> (-0.02%) ⬇️
windows 41.09% <ø> (-0.01%) ⬇️
ydb-23.3 47.62% <ø> (-0.17%) ⬇️
ydb-24.1 52.02% <ø> (-0.43%) ⬇️
ydb-24.2 51.95% <ø> (-0.50%) ⬇️
ydb-nightly 70.77% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vladislav Polyakov <[email protected]>
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 29, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 29, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 29, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 29, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 29, 2024
@asmyasnikov asmyasnikov merged commit 9a4b4f8 into master Dec 6, 2024
27 checks passed
@asmyasnikov asmyasnikov deleted the add-devcontainer branch December 6, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants