Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patitioning info to describe table #1594

Conversation

fexolm
Copy link
Member

@fexolm fexolm commented Dec 18, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@fexolm fexolm force-pushed the fexolm/add-sharding-info branch from eaea3fa to 9f2849d Compare December 18, 2024 14:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (exp-multitable-bulkupsert@34bdb88). Learn more about missing BASE report.

Files with missing lines Patch % Lines
scheme/scheme.go 30.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             exp-multitable-bulkupsert    #1594   +/-   ##
============================================================
  Coverage                             ?   52.36%           
============================================================
  Files                                ?      356           
  Lines                                ?    36143           
  Branches                             ?        0           
============================================================
  Hits                                 ?    18925           
  Misses                               ?    16003           
  Partials                             ?     1215           
Flag Coverage Δ
go-1.21.x 51.82% <30.00%> (?)
go-1.22.x 51.98% <30.00%> (?)
go-1.23.x 52.07% <30.00%> (?)
integration 52.36% <30.00%> (?)
ubuntu 52.36% <30.00%> (?)
ydb-23.3 47.56% <30.00%> (?)
ydb-24.1 52.20% <30.00%> (?)
ydb-24.2 52.07% <30.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 2bf7eb9 into ydb-platform:exp-multitable-bulkupsert Dec 18, 2024
27 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants