-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added function id into database/sql traces (start info's) + Fix of breaking changes #889
Conversation
github.com/ydb-platform/ydb-go-sdk/v3/traceincompatible changesDatabaseSQLOnConnBegin: changed from func(*DatabaseSQL, *context.Context) func(tx tableTransactionInfo, _ error) to func(*DatabaseSQL, *context.Context, call) func(tx tableTransactionInfo, _ error) compatible changesDatabaseSQLConnBeginStartInfo.Call: added summaryBase version: v3.54.2-rc0 (master) |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
==========================================
- Coverage 66.78% 66.74% -0.05%
==========================================
Files 257 257
Lines 24266 24276 +10
==========================================
- Hits 16207 16202 -5
- Misses 7222 7235 +13
- Partials 837 839 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Fix of breaking changes
🌋 Here are results of SLO test for Go SDK xorm: |
🌋 Here are results of SLO test for Go SDK database/sql: |
🌋 Here are results of SLO test for Go SDK native: |
🌋 Here are results of SLO test for Go SDK gorm: |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information