Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function id into database/sql traces (start info's) + Fix of breaking changes #889

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github-actions bot commented Nov 9, 2023

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

DatabaseSQLOnConnBegin: changed from func(*DatabaseSQL, *context.Context) func(tx tableTransactionInfo, _ error) to func(*DatabaseSQL, *context.Context, call) func(tx tableTransactionInfo, _ error)
DatabaseSQLOnConnClose: changed from func(*DatabaseSQL) func(error) to func(*DatabaseSQL, *context.Context, call) func(error)
DatabaseSQLOnConnExec: changed from func(*DatabaseSQL, *context.Context, string, string, bool, time.Duration) func(error) to func(*DatabaseSQL, *context.Context, call, string, string, bool, time.Duration) func(error)
DatabaseSQLOnConnPing: changed from func(*DatabaseSQL, *context.Context) func(error) to func(*DatabaseSQL, *context.Context, call) func(error)
DatabaseSQLOnConnPrepare: changed from func(*DatabaseSQL, *context.Context, string) func(error) to func(*DatabaseSQL, *context.Context, call, string) func(error)
DatabaseSQLOnConnQuery: changed from func(*DatabaseSQL, *context.Context, string, string, bool, time.Duration) func(error) to func(*DatabaseSQL, *context.Context, call, string, string, bool, time.Duration) func(error)
DatabaseSQLOnConnectorConnect: changed from func(*DatabaseSQL, *context.Context) func(_ error, session tableSessionInfo) to func(*DatabaseSQL, *context.Context, call) func(_ error, session tableSessionInfo)
DatabaseSQLOnDoTx: changed from func(*DatabaseSQL, *context.Context, string, bool) func(error) func(attempts int, _ error) to func(*DatabaseSQL, *context.Context, call, string, bool) func(error) func(attempts int, _ error)
DatabaseSQLOnStmtClose: changed from func(*DatabaseSQL, *context.Context) func(error) to func(*DatabaseSQL, *context.Context, call) func(error)
DatabaseSQLOnStmtExec: changed from func(*DatabaseSQL, *context.Context, *context.Context, string) func(error) to func(*DatabaseSQL, *context.Context, call, *context.Context, string) func(error)
DatabaseSQLOnStmtQuery: changed from func(*DatabaseSQL, *context.Context, *context.Context, string) func(error) to func(*DatabaseSQL, *context.Context, call, *context.Context, string) func(error)
DatabaseSQLOnTxCommit: changed from func(*DatabaseSQL, *context.Context, tableTransactionInfo) func(error) to func(*DatabaseSQL, *context.Context, call, tableTransactionInfo) func(error)
DatabaseSQLOnTxExec: changed from func(*DatabaseSQL, *context.Context, *context.Context, tableTransactionInfo, string) func(error) to func(*DatabaseSQL, *context.Context, call, *context.Context, tableTransactionInfo, string, bool) func(error)
DatabaseSQLOnTxPrepare: changed from func(*DatabaseSQL, *context.Context, *context.Context, tableTransactionInfo, string) func(error) to func(*DatabaseSQL, *context.Context, call, *context.Context, tableTransactionInfo, string) func(error)
DatabaseSQLOnTxQuery: changed from func(*DatabaseSQL, *context.Context, *context.Context, tableTransactionInfo, string) func(error) to func(*DatabaseSQL, *context.Context, call, *context.Context, tableTransactionInfo, string, bool) func(error)
DatabaseSQLOnTxRollback: changed from func(*DatabaseSQL, *context.Context, tableTransactionInfo) func(error) to func(*DatabaseSQL, *context.Context, call, tableTransactionInfo) func(error)

compatible changes

DatabaseSQLConnBeginStartInfo.Call: added
DatabaseSQLConnCloseStartInfo.Call: added
DatabaseSQLConnCloseStartInfo.Context: added
DatabaseSQLConnExecStartInfo.Call: added
DatabaseSQLConnPingStartInfo.Call: added
DatabaseSQLConnPrepareStartInfo.Call: added
DatabaseSQLConnQueryStartInfo.Call: added
DatabaseSQLConnectorConnectStartInfo.Call: added
DatabaseSQLDoTxStartInfo.Call: added
DatabaseSQLStmtCloseStartInfo.Call: added
DatabaseSQLStmtExecStartInfo.Call: added
DatabaseSQLStmtQueryStartInfo.Call: added
DatabaseSQLTxCommitStartInfo.Call: added
DatabaseSQLTxExecStartInfo.Call: added
DatabaseSQLTxExecStartInfo.Idempotent: added
DatabaseSQLTxPrepareStartInfo.Call: added
DatabaseSQLTxQueryStartInfo.Call: added
DatabaseSQLTxQueryStartInfo.Idempotent: added
DatabaseSQLTxRollbackStartInfo.Call: added

summary

Base version: v3.54.2-rc0 (master)
Suggested version: v3.54.2

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (13c5744) 66.78% compared to head (1add019) 66.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
- Coverage   66.78%   66.74%   -0.05%     
==========================================
  Files         257      257              
  Lines       24266    24276      +10     
==========================================
- Hits        16207    16202       -5     
- Misses       7222     7235      +13     
- Partials      837      839       +2     
Flag Coverage Δ
53.34% <70.00%> (-0.06%) ⬇️
go-1.17.x 65.37% <70.00%> (+0.08%) ⬆️
go-1.20.x 66.59% <70.00%> (-0.03%) ⬇️
go-1.21.x 66.64% <70.00%> (+0.08%) ⬆️
integration 53.34% <70.00%> (-0.06%) ⬇️
macOS 38.95% <0.00%> (+<0.01%) ⬆️
ubuntu 38.95% <0.00%> (-0.04%) ⬇️
unit 39.05% <0.00%> (-0.01%) ⬇️
windows 39.03% <0.00%> (-0.02%) ⬇️
ydb-22.5 52.91% <70.00%> (-0.18%) ⬇️
ydb-23.1 53.09% <70.00%> (+0.15%) ⬆️
ydb-23.2 53.11% <70.00%> (+0.08%) ⬆️
ydb-23.3 53.06% <70.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/xsql/conn.go 56.67% <100.00%> (+0.29%) ⬆️
internal/xsql/connector.go 59.86% <100.00%> (+0.55%) ⬆️
internal/xsql/stmt.go 63.15% <100.00%> (ø)
internal/xsql/tx.go 57.14% <100.00%> (ø)
internal/xsql/tx_fake.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 9, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Nov 9, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

Copy link

github-actions bot commented Nov 9, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

Copy link

github-actions bot commented Nov 9, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@asmyasnikov asmyasnikov merged commit 4e5ae05 into master Nov 9, 2023
48 of 49 checks passed
@asmyasnikov asmyasnikov deleted the fix branch November 9, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants